-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with papirus-folders #83
Comments
After a bit of thinking, I wanted to make this a bit more flexible and not just lock it to the colors for papirus-folders. I thought about adding something like this: colors_to_compare = [
{ name = "white", color = "#ffffff" },
{ name = "black", color = "#000000" }
]
compare_against = "primary" Matugen would loop over all the colors, compare them with the other color and output the closest one inside of the list by using the I'm not sure if this is the best way or the easiest one, if you have any other ideas feel free to share them. |
I think this flexibility is the correct path, and I want to suggest perhaps the concept of hook, like this:
matugen already has this with gtk (when running matugen it will call the hook that will use gsettings to set adw-gtk), but it is harcoded just for him, maybe making this flexible for templates would be interesting, like this:
I saw this hook concept in this program: https://github.com/Misterio77/flavours?tab=readme-ov-file#setup |
I forgot to make them execute stuff, I'll fix it later. For now, here's an example for the hook: [templates.name1]
input_path = "example/colors.whatever-extension"
output_path = "example/a/colors-generated.whatever-extension"
colors_to_compare = [
{ name = "black", color = "#000000" },
{ name = "red", color = "#ff0000" },
{ name = "maroon", color = "#800000" },
{ name = "yellow", color = "#ffff00" },
{ name = "olive", color = "#808000" },
{ name = "lime", color = "#00ff00" },
{ name = "green", color = "#008000" },
{ name = "aqua", color = "#00ffff" },
{ name = "teal", color = "#008080" },
{ name = "blue", color = "#0000ff" },
{ name = "navy", color = "#000080" },
{ name = "fuchsia", color = "#ff00ff" },
{ name = "purple", color = "#800080" },
]
compare_to = "#aefbd5"
hook = "source color {source_color}, source image {source_image}, compared color {compared_color}" |
In like that: |
No but I'll make it do that if you want. |
If there is no negative side, it might be interesting to implement |
It executes now, so feel free to test stuff. |
In the case of papirus-folders I don't need an
Would it be a good idea to implement this, these "special" cases? |
I already added the |
Okay, I was unsure about the name |
I decided to rename it, Also added formatting to |
Kooha-2024-06-29-20-19-06.mp4 |
Testing here, in some wallpapers it gets it right, in others it refuses and chooses only the here is a "log": |
Could you post the wallpapers this is happening with? |
I will post others |
I was testing these colors which would be the colors of the papirus-folders folders that I got using the color picker, would it be better to use the template you provided?
|
I would use the papirus-folders colors and maybe add some middle colors, while naming it the same as the color you want to get. |
I'm almost reaching the perfect rice, but I didn't find an easy way to select the available colors of papirus-folders based on accent_color in matugen
https://github.com/PapirusDevelopmentTeam/papirus-folders
The text was updated successfully, but these errors were encountered: