Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of progress bars #152

Open
tfardet opened this issue Jun 14, 2023 · 1 comment
Open

Improve handling of progress bars #152

tfardet opened this issue Jun 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@tfardet
Copy link
Collaborator

tfardet commented Jun 14, 2023

At the moment, pynsee uses tqdm for progress bars.
It's a very solid library that does the job perfectly but it does not interact well with... basically anything.
So right now, any code or library using pynsee internally will have to accept having progress bars popping everywhere.

I think it would be nice to provide better options for handling them. I see to main options:

  1. the simpler option is to provide one global parameter to hide progress (setting disable=True to the tqdm object)
  2. switch to rich.progress, which, as far as I know, is the only library that supports nested progress bars; one would then have a global progress object that people could use to add other progress bars or simply disable them
@tfardet tfardet added the enhancement New feature or request label Jun 14, 2023
@hadrilec
Copy link
Contributor

fine for me, I would go for the simplest option so the first one, if anyone is willing to make a PR on this, he/she is welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants