Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In case of BeanInstanceCreationException, clear resolution stack to avoid "Cyclic call while resolving $beanDefinition" #110

Closed
sofiaguyang opened this issue Apr 19, 2018 · 2 comments
Closed

In case of BeanInstanceCreationException, clear resolution stack to avoid "Cyclic call while resolving $beanDefinition" #110

sofiaguyang opened this issue Apr 19, 2018 · 2 comments
Labels
core status:accepted accepted to be developed type:issue
Milestone
1.0.0

Comments

@sofiaguyang
Copy link

In the case of BeanInstanceCreationException, the bean definitions in the stack in ResolutionStack are not popped out. The next time I try to get a bean from the context, I get the error: Cyclic call while resolving $beanDefinition.

Thinking BeanInstanceCreationException must be caught to trigger the clearing of the stack and then re-thrown.
@arnaudgiuliani arnaudgiuliani added this to the 1.0.0 milestone Apr 19, 2018
@arnaudgiuliani
Copy link
Member

Ok, we need to clear the ResolutionStackon error.

Thanks.

@arnaudgiuliani arnaudgiuliani added status:accepted accepted to be developed type:issue and removed type:enhancement labels May 2, 2018
@arnaudgiuliani
Copy link
Member

Fixed in 1.0.0-alpha-4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core status:accepted accepted to be developed type:issue
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@arnaudgiuliani @sofiaguyang