Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BuildConfig is enabled for koin Android and Koin Compose #1631

Closed
Nek-12 opened this issue Aug 5, 2023 · 1 comment
Closed

BuildConfig is enabled for koin Android and Koin Compose #1631

Nek-12 opened this issue Aug 5, 2023 · 1 comment

Comments

@Nek-12
Copy link

Nek-12 commented Aug 5, 2023

I'm tired of seeing BuildConfig of koin in all my modules. Build config should be disabled for library modules as it's an anti-pattern in library development.

image

The solution is to disable buildconfig for koin modules.
5peak2me pushed a commit to 5peak2me/koin that referenced this issue Sep 4, 2023
Fix InsertKoinIO#1631, Disable BuildConfig for android modules
6bdfbcb
arnaudgiuliani added a commit that referenced this issue Sep 4, 2023
@arnaudgiuliani
Merge pull request #1642 from 5peak2me/main
293821a 
Fix #1631, Disable BuildConfig for android modules
@5peak2me
Copy link

5peak2me commented Sep 4, 2023

This question can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arnaudgiuliani @5peak2me @Nek-12