Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Koin 3.5.3 -> 3.5.4 removes dep on kotlin-test #1848

Closed
yogurtearl opened this issue Apr 10, 2024 · 1 comment
Closed

Upgrading Koin 3.5.3 -> 3.5.4 removes dep on kotlin-test #1848

yogurtearl opened this issue Apr 10, 2024 · 1 comment

Comments

@yogurtearl
Copy link

yogurtearl commented Apr 10, 2024

PR #1802 removes kotlin-test as a transitive dependency.

It is a good change, but also a breaking change which should probably be saved for a major version bump (or minor), not added in a patch release.

This is will break anyone that was relying on kotlin-test at compile or runtime (which they shouldn't have been doing in the first place, but https://xkcd.com/1172/ )

The solution is to add something like testImplementation("org.jetbrains.kotlin:kotlin-test:$kotlinVersion")

Mostly just opening this for documentation purposes, feel free to close it.

@arnaudgiuliani
Copy link
Member

problem is some side impact of complete rewrite of Gradle Kotlin DSL 🙄 This is why I asked feedback on RC releases :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants