Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use disparity filter twice to post process the depth image? #826

Closed
zinan93 opened this issue Jun 24, 2019 · 2 comments
Closed

How to use disparity filter twice to post process the depth image? #826

zinan93 opened this issue Jun 24, 2019 · 2 comments

Comments

@zinan93
Copy link

zinan93 commented Jun 24, 2019

Hi, I know that filters can be specified in the launch file and that the parameters such as decimation scale can be set using dynamic reconfigure. But how do I convert the depth frame to disparity domain, do some temporal filtering, convert it back and then apply hole_filling? I tried the the following change in the rs_camera.launch file:

arg name="filters" default="decimation,disparity,spatial,temporal,disparity,hole_filling"

and got the following result:
image

it seems like the order of the sequence is not right, and only one disparity filter appeared.

@doronhi
Copy link
Contributor

doronhi commented Jun 25, 2019

Current filters interface is not as flexible as using the raw librealsense2 functionality.
Setting filter "disparity" encapsulate the other filters inside a disparity section, no matter how many times you specify disparity, it only appears once.
Decimation filter will be added only once and at the beginning of the filters queue.
You can check the code of the function setupFilters for a better understanding of the current situation and its limitations.

@zinan93
Copy link
Author

zinan93 commented Jun 26, 2019

Ok I see, thank you. So the disparity filter is added to the beginning and end of the _filters vector after other filters has been pushed, then the decimation goes to the very beginning. Meaning the hole_filling filter will be applied in the disparity domain then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants