Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Problem with cardano-cli genesis create-cardano --gen-utxo-keys #4725

Closed
CarlosLopezDeLara opened this issue Dec 20, 2022 · 4 comments · Fixed by #4761
Closed

[BUG] - Problem with cardano-cli genesis create-cardano --gen-utxo-keys #4725

CarlosLopezDeLara opened this issue Dec 20, 2022 · 4 comments · Fixed by #4761
Assignees
Labels
comp: cardano-cli type: bug Something is not working user type: internal Created by an IOG employee

Comments

@CarlosLopezDeLara
Copy link
Contributor

Internal/External
Internal

Area
cardano-cli

Summary
When running cardano-cli genesis create-cardano the option --gen-utxo-keys has no effect at all.

It's supposed to default to zero, however it always creates one utxo key with the amount in --supply

  --gen-utxo-keys INT      The number of UTxO keys to make [default is 0].

Also, using --gen-utxo-keys with N > 1 does not change anything. Only one key is produced.

Steps to reproduce

  1. Get template files from cardano-world
  2. Run
cardano-cli genesis create-cardano \
--genesis-dir ./ \
--gen-genesis-keys 3 \
--gen-utxo-keys 3 \
--start-time $(date -u -d "now + 2 minutes" +%FT%Tz) \
--supply 30000000000000000 \
--security-param 45 \
--slot-length 100 \
--slot-coefficient 5/100 \
--testnet-magic 42 \
--byron-template template/byron.json \
--shelley-template template/shelley.json \
--alonzo-template template/alonzo.json \
--node-config-template template/config.json
  1. The folder utxo-keys will contain only 1 set of utxo keys:
utxo-keys/
├── byron.000.key
├── shelley.000.skey
└── shelley.000.vkey

0 directories, 3 files

Expected behavior
It should either be explicit about numUtxoKeys being hardcoded to 1 or generate as many keys as the user sets in --gen-utxo-keys

System info (please complete the following information):

$ cardano-node --version
cardano-node 1.35.4 - linux-x86_64 - ghc-8.10
git rev ebc7be471b30e5931b35f9bbc236d21c375b91bb
$ cardano-cli --version
cardano-cli 1.35.4 - linux-x86_64 - ghc-8.10
git rev ebc7be471b30e5931b35f9bbc236d21c375b91bb
@dorin100 dorin100 added the user type: internal Created by an IOG employee label Dec 28, 2022
@MarcFontaine MarcFontaine self-assigned this Jan 6, 2023
@MarcFontaine
Copy link
Contributor

The parameter is ignored in the actual implementation.
There is also a LOC where 1 is hardcode. It looks like this is easy to fix,
but could not find the right template files...
Where exactly did you find the template files ?

@CarlosLopezDeLara
Copy link
Contributor Author

@MarcFontaine
Copy link
Contributor

MarcFontaine commented Jan 9, 2023

I think #4761 fixes it, but please double-check.

@CarlosLopezDeLara
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: cardano-cli type: bug Something is not working user type: internal Created by an IOG employee
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@MarcFontaine @dorin100 @CarlosLopezDeLara and others