Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mp4 videos are not displayed when deployed on github.io #12

Open
coot opened this issue Sep 27, 2022 · 9 comments
Open

mp4 videos are not displayed when deployed on github.io #12

coot opened this issue Sep 27, 2022 · 9 comments

Comments

@coot
Copy link
Collaborator

coot commented Sep 27, 2022

See https://input-output-hk.github.io/cardano-updates/posts/2022-09-27-network.html

@ghost
Copy link

ghost commented Oct 30, 2022

I think the files are somehow corrupted: I could not open the files locally either with QuickTime or VLC.

@dnadales
Copy link
Member

I can play this locally with mplayer, vlc, and totem. It is also correctly identified by file:

images/p2p-relay-5.mp4: ISO Media, MP4 Base Media v1 [ISO 14496-12:2003]

@ghost
Copy link

ghost commented Oct 31, 2022

Here is what I have from a fresh checkout on Mac OS X:

s % ls -la images
total 296
drwxr-xr-x   8 arnaud  staff    256 Oct 31 11:20 .
drwxr-xr-x  22 arnaud  staff    704 Oct 31 11:20 ..
-rw-r--r--   1 arnaud  staff  46231 Oct 31 11:20 happy-path-csj-prototype-bench-1.svg
-rw-r--r--   1 arnaud  staff  48117 Oct 31 11:20 happy-path-csj-prototype-bench-2.svg
-rw-r--r--   1 arnaud  staff  35978 Oct 31 11:20 happy-path-csj-prototype-prelim.svg
-rw-r--r--   1 arnaud  staff   5674 Oct 31 11:20 haskell-logo.png
-rw-r--r--   1 arnaud  staff    133 Oct 31 11:20 p2p-relay-5.mp4
-rw-r--r--   1 arnaud  staff    133 Oct 31 11:20 p2p-relay3.mp4

and then

s % cat images/p2p-relay-5.mp4
version https://git-lfs.github.com/spec/v1
oid sha256:c47ba3e2aa570664b189bd12139959db071550c4efa3cadfd915193ddd4c39bd
size 86690301

What am I doing wrong?

@dnadales
Copy link
Member

Perhaps you're missing https://git-lfs.github.com/

We should mention this in the README :/

@ghost
Copy link

ghost commented Oct 31, 2022

Indeed. And perhaps the GH action is missing it too :)

@ghost
Copy link

ghost commented Oct 31, 2022

Or not using it at all?

@ghost
Copy link

ghost commented Oct 31, 2022

I understand it's annoying to store large video files in Git, but perhaps we should just store them elsewhere and only reference them in markdown by URL?

@coot
Copy link
Collaborator Author

coot commented Oct 31, 2022

It would be much nicer to store them elsewhere, any suggestion? Maybe we could serve them from google 🤦‍♂️ 😄

@ghost
Copy link

ghost commented Nov 1, 2022

I think that would make sense: Upload the videos to a shared google driver directory and make world readable. Requiring people (or the CI) to install a git extension does not seem very UX-friendly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants