From a785df05c51f73d933bf5fa6fc650201998ed196 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Sza=C5=82owski?= Date: Tue, 19 Mar 2024 19:00:20 +0100 Subject: [PATCH] [#512] chore: add type checking & lint workflow to github actions --- .../workflows/code_style_check_frontend.yml | 37 +++++++++++++++++++ CHANGELOG.md | 1 + govtool/frontend/package.json | 1 + 3 files changed, 39 insertions(+) create mode 100644 .github/workflows/code_style_check_frontend.yml diff --git a/.github/workflows/code_style_check_frontend.yml b/.github/workflows/code_style_check_frontend.yml new file mode 100644 index 000000000..cf4486159 --- /dev/null +++ b/.github/workflows/code_style_check_frontend.yml @@ -0,0 +1,37 @@ +name: Frontend Lint & Type Check + +on: + push: + paths: + - govtool/frontend/** + - .github/workflows/code_check_frontend.yml + +jobs: + code_check: + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Cache dependencies + uses: actions/cache@v2 + with: + path: govtool/frontend/node_modules + key: ${{ runner.os }}-node-${{ hashFiles('govtool/frontend/package-lock.json') }} + + - name: Set up Node.js + uses: actions/setup-node@v4 + with: + node-version: "18.x" + + - name: Install dependencies + working-directory: govtool/frontend + run: npm install + + - name: Lint + working-directory: govtool/frontend + run: npm run lint + + - name: Type Check + working-directory: govtool/frontend + run: npm run tsc diff --git a/CHANGELOG.md b/CHANGELOG.md index 66f7e2413..7bafec6db 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ changes. - Add hash and validation of the metadata [Issue 378](https://github.com/IntersectMBO/govtool/issues/378) - Add githubusercontent.com and ipfs.io to content security policy header [Issue 451](https://github.com/IntersectMBO/govtool/issues/451) - Add frontend test workflow on github actions [Issue 500](https://github.com/IntesectMBO/govtool/issues/500) +- Add type check & lint to github actions [Issue 512](https://github.com/IntesectMBO/govtool/issues/512) ### Added diff --git a/govtool/frontend/package.json b/govtool/frontend/package.json index 8ce160dd4..523792b81 100644 --- a/govtool/frontend/package.json +++ b/govtool/frontend/package.json @@ -7,6 +7,7 @@ "dev": "vite", "build": "vite build", "lint": "eslint src --ext ts,tsx --report-unused-disable-directives --max-warnings 0", + "tsc": "tsc --noEmit --skipLibCheck", "preview": "vite preview", "storybook": "storybook dev -p 6006", "build-storybook": "storybook build",