Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Persistant "Wallet Connected" Toast Disrupts Testing #1181

Closed
kneerose opened this issue Jun 6, 2024 · 4 comments
Closed

[BUG] Persistant "Wallet Connected" Toast Disrupts Testing #1181

kneerose opened this issue Jun 6, 2024 · 4 comments
Assignees
Labels
🐛 Bug Something isn't working

Comments

@kneerose
Copy link
Contributor

kneerose commented Jun 6, 2024

Context & versions

  • The application displays a "wallet connected" toast message every time it's opened when a wallet is already connected. This toast interferes with automated tests, causing flakiness and hindering test interaction.

Steps to reproduce

  • Navigate to the app while a wallet is connected.
  • Observe the "wallet connected" toast notification.

Impact:

  • Automated tests are rendered unreliable due to the persistent toast.
  • Test interactions are disrupted by the toast presence.

Reference test reports

above mention, tests are currently blocked due to this toast.

@NabinKawan NabinKawan added the 🐛 Bug Something isn't working label Jun 6, 2024
@pmbinapps
Copy link

A decision is need how this feature should be used to inform user about wallet connection status.

@MSzalowski
Copy link
Contributor

Wallet reconnects every time the page is being refreshed. That is to prevent the situation when the wallet looses its connection on refresh (which is possible on such action).

Every time when wallet is being reconnected, the toast is displayed informing the user about the successful connection. I wouldn't call it as a bug, is it any way to bypass the wallet connect toast on your tests using the test ids?

@bosko-m
Copy link
Contributor

bosko-m commented Jul 3, 2024

@kneerose Whats your opinion on this?

@kneerose
Copy link
Contributor Author

kneerose commented Jul 3, 2024

@bosko-m we already handle this.

@kneerose kneerose closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

6 participants