Tomcat8 role does not work with tags

[whikloj]

The things in the main.yml of the the ansible-role-tomcat8 are not run if you use the -t | --tags with ansible-playbook

For example.

> ansible-playbook -i inventory/vagrant -e"islandora_distro=ubuntu/xenial64" -t fcrepo-syn,tomcat8 -u vagrant playbook.yml
[DEPRECATION WARNING]: 'include' for playbook includes. You should use 'import_playbook' instead. This feature will be removed in version 2.8. Deprecation warnings can be disabled by setting 
deprecation_warnings=False in ansible.cfg.
[DEPRECATION WARNING]: The use of 'include' for tasks has been deprecated. Use 'import_tasks' for static inclusions or 'include_tasks' for dynamic inclusions. This feature will be removed in a future release. 
Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
[DEPRECATION WARNING]: include is kept for backwards compatibility but usage is discouraged. The module documentation details page may explain more about this rationale.. This feature will be removed in a 
future release. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
[DEPRECATION WARNING]: The use of 'static' has been deprecated. Use 'import_tasks' for static inclusion, or 'include_tasks' for dynamic inclusion. This feature will be removed in a future release. Deprecation 
warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

PLAY [bootstrap] *************************************************************************************************************************************************************************************************

PLAY [database] **************************************************************************************************************************************************************************************************

TASK [Gathering Facts] *******************************************************************************************************************************************************************************************
Monday 19 November 2018  09:18:29 -0600 (0:00:00.078)       0:00:00.078 ******* 
ok: [default]

PLAY [solr] ******************************************************************************************************************************************************************************************************

TASK [Gathering Facts] *******************************************************************************************************************************************************************************************
Monday 19 November 2018  09:18:30 -0600 (0:00:01.027)       0:00:01.105 ******* 
ok: [default]

PLAY [webserver] *************************************************************************************************************************************************************************************************

TASK [Gathering Facts] *******************************************************************************************************************************************************************************************
Monday 19 November 2018  09:18:30 -0600 (0:00:00.621)       0:00:01.727 ******* 
ok: [default]

PLAY [tomcat] ****************************************************************************************************************************************************************************************************

TASK [Gathering Facts] *******************************************************************************************************************************************************************************************
Monday 19 November 2018  09:18:31 -0600 (0:00:00.610)       0:00:02.338 ******* 
ok: [default]

TASK [Islandora-Devops.tomcat8 : include] ************************************************************************************************************************************************************************
Monday 19 November 2018  09:18:31 -0600 (0:00:00.581)       0:00:02.919 ******* 
included: /sw/var/www/DAM2/claw-playbook/roles/external/Islandora-Devops.tomcat8/tasks/install-Debian.yml for default

TASK [Islandora-Devops.tomcat8 : install tomcat8] ****************************************************************************************************************************************************************
Monday 19 November 2018  09:18:32 -0600 (0:00:00.051)       0:00:02.971 ******* 
ok: [default] => (item=[u'tomcat8'])

TASK [Islandora-Devops.tomcat8 : install tomcat8 admin] **********************************************************************************************************************************************************
Monday 19 November 2018  09:18:37 -0600 (0:00:05.875)       0:00:08.846 ******* 
ok: [default] => (item=[u'tomcat8-admin'])

TASK [Islandora-Devops.tomcat8 : start tomcat8] ******************************************************************************************************************************************************************
Monday 19 November 2018  09:18:38 -0600 (0:00:00.593)       0:00:09.440 ******* 
ok: [default]

TASK [Islandora-Devops.tomcat8 : include] ************************************************************************************************************************************************************************
Monday 19 November 2018  09:18:38 -0600 (0:00:00.464)       0:00:09.904 ******* 
 [WARNING]: Ignoring invalid attribute: sudo

included: /sw/var/www/DAM2/claw-playbook/roles/external/Islandora-Devops.tomcat8/tasks/config.yml for default

TASK [Islandora-Devops.tomcat8 : template /etc/default/tomcat8] **************************************************************************************************************************************************
Monday 19 November 2018  09:18:39 -0600 (0:00:00.053)       0:00:09.958 ******* 
ok: [default]

TASK [Islandora-Devops.tomcat8 : template {{tomcat8_home}}/bin/setenv.sh] ****************************************************************************************************************************************
Monday 19 November 2018  09:18:39 -0600 (0:00:00.920)       0:00:10.878 ******* 
skipping: [default]

TASK [Islandora-Devops.tomcat8 : server configuration] ***********************************************************************************************************************************************************
Monday 19 November 2018  09:18:39 -0600 (0:00:00.034)       0:00:10.912 ******* 
fatal: [default]: FAILED! => {"failed": true, "msg": "The task includes an option with an undefined variable. The error was: 'tomcat8_home' is undefined\n\nThe error appears to have been in '/sw/var/www/DAM2/claw-playbook/roles/external/Islandora-Devops.tomcat8/tasks/config.yml': line 17, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: server configuration\n  ^ here\n\nexception type: <class 'ansible.errors.AnsibleUndefinedVariable'>\nexception: 'tomcat8_home' is undefined"}
	to retry, use: --limit @/sw/var/www/DAM2/claw-playbook/playbook.retry

PLAY RECAP *******************************************************************************************************************************************************************************************************
default                    : ok=10   changed=0    unreachable=0    failed=1   

Monday 19 November 2018  09:18:39 -0600 (0:00:00.023)       0:00:10.936 ******* 
=============================================================================== 
Islandora-Devops.tomcat8 : install tomcat8 ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 5.88s
Gathering Facts ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 1.03s
Islandora-Devops.tomcat8 : template /etc/default/tomcat8 -------------------------------------------------------------------------------------------------------------------------------------------------- 0.92s
Gathering Facts ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 0.62s
Gathering Facts ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 0.61s
Islandora-Devops.tomcat8 : install tomcat8 admin ---------------------------------------------------------------------------------------------------------------------------------------------------------- 0.59s
Gathering Facts ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 0.58s
Islandora-Devops.tomcat8 : start tomcat8 ------------------------------------------------------------------------------------------------------------------------------------------------------------------ 0.46s
Islandora-Devops.tomcat8 : include ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 0.05s
Islandora-Devops.tomcat8 : include ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 0.05s
Islandora-Devops.tomcat8 : template {{tomcat8_home}}/bin/setenv.sh ---------------------------------------------------------------------------------------------------------------------------------------- 0.03s
Islandora-Devops.tomcat8 : server configuration ----------------------------------------------------------------------------------------------------------------------------------------------------------- 0.02s

So we need to either add

tags:
  - tomcat8
  - tomcat8-config
  - tomcat8-install

to all of these

or (and this is probably cleaner) move them to a new file (like define-home.yml) and add that to the top of the main.yml with all 3 tags. For example

- include: "define-home.yml"
   tags:
     - tomcat8
     - tomcat8-config
     - tomcat8-install

[dbernstein]

I'm dipping my toes into the Islandora CLAW creek here. Can someone (@whikloj ) assign this one to me?

[dannylamb]

@dbernstein I've sent you an invite to the CLAW org. You should be able to have tickets assigned to you after that.