Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump S6-Overlay when the following issues will be resolved in their next release. #269

Closed
nigelgbanks opened this issue Dec 7, 2022 · 3 comments · Fixed by #321
Closed
Assignees
Labels
bug Something isn't working

Comments

@nigelgbanks
Copy link
Contributor

Issue: just-containers/s6-overlay#503

Basically, our finish script checks to see if all the services exited gracefully when receiving a SIGTERM. If so, they exit 0, if not, they exit with 128+15=143, to indicate that the service exited due to an unhandled SIGTERM (15). The issue above is where a service triggers the container to exit by calling halt after it has exited, in which case s6-overlay is not respecting S6_SERVICES_GRACETIME value and immediately calling SIGKILL on the remaining services rather than waiting for the grace time.

This by and large only effects the JAVA services (ActiveMQ, Fcrepo, etc) which is fortunate in that they are typically the only service running in the container (so not affected by the bug), except when we are also running tests, as the tests are additional services.

@nigelgbanks
Copy link
Contributor Author

Hmm, in the meanwhile I'll just update the tests to accept a list of exit codes (rather than a singular value), and we'll remove the acceptance of 143 later after the issue in s6-overlay is resolved.

@nigelgbanks nigelgbanks self-assigned this Dec 7, 2022
@nigelgbanks nigelgbanks added the bug Something isn't working label Dec 7, 2022
@rosiel
Copy link
Contributor

rosiel commented Oct 25, 2023

Is this still an issue?

@nigelgbanks
Copy link
Contributor Author

Yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants