Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 #293

Closed
rosiel opened this issue Oct 25, 2023 · 4 comments
Closed

PHP 8.2 #293

rosiel opened this issue Oct 25, 2023 · 4 comments
Assignees

Comments

@rosiel
Copy link
Contributor

rosiel commented Oct 25, 2023

PHP 8.1 is leaving active support on 25 November 2023. We should update to PHP 8.2.

@rosiel
Copy link
Contributor Author

rosiel commented Oct 25, 2023

This is to say, I'm tapping out - I can't install this, the stack is too complex.

@aOelschlager
Copy link
Contributor

aOelschlager commented Oct 30, 2023

@nigelgbanks I started to try and tackle this maybe a month ago and everything seemed to build ok with the exception of crayfits. Here's my branch for it:
https://github.com/aOelschlager/isle-buildkit/tree/php-8-2

This is the error I was seeing:

[crayfits stage-0 4/7] RUN --mount=type=bind,source=rootfs/var/www/crayfits/composer.lock,target=/var/www/crayfits/composer.lock     composer install -d /var/www/crayfits &&     cleanup.sh:
0.571 /usr/local/bin/composer: line 9: php: command not found
------
Dockerfile:32
--------------------
  31 |     
  32 | >>> RUN --mount=type=bind,source=rootfs/var/www/crayfits/composer.lock,target=/var/www/crayfits/composer.lock \
  33 | >>>     composer install -d /var/www/crayfits && \
  34 | >>>     cleanup.sh
  35 |     
--------------------
ERROR: failed to solve: process "/bin/bash -euo pipefail -c composer install -d /var/www/crayfits &&     cleanup.sh" did not complete successfully: exit code: 127
make: *** [Makefile:195: bake] Error 1

I'm not going to pursue this further but I thought I would share what I ran into since you understand this stuff way better than I do.

@nigelgbanks
Copy link
Contributor

Started a draft here #299. I have to test to determine if a major version change is warranted or if a minor would suffice.

@nigelgbanks
Copy link
Contributor

Hmm seems major is needed as this will break Drupal 9 installs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants