Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] hook_install() term creation failures during site installation from --existing-config #13

Closed
adam-vessey opened this issue Nov 15, 2022 · 1 comment · Fixed by #21
Assignees
Labels
bug Something isn't working

Comments

@adam-vessey
Copy link
Contributor

adam-vessey commented Nov 15, 2022

What steps does it take to reproduce the issue?

  • When does this issue occur?

Site installation using an --existing-config, with this module enabled.

  • Which page does it occur on?

N/A

  • What happens?

Don't recall the exact error, but it will attempt to create the term before the islandora_display taxonomy itself is configured, due to the site installation flow (was encountered previously with islandora_fits when dealing with the islandora-starter-site):

  • enabling the module and running install hooks; before
  • importing the existing configuration (which defines the taxonomy)

... looking back at roblib/islandora_fits#12 , I'm not sure there's an explicit error, but just that the term will probably not carry the intended value for field_external_uri, but will instead be left blank.

  • To whom does it occur (anonymous visitor, editor, administrator)?

Sys admin.

  • What did you expect to happen?

The term to be able to be created without error.

Which version of Islandora are you using?

N/A

Any related open or closed issues to this bug report?

Same class of issue as roblib/islandora_fits#14

Screenshots:

@adam-vessey adam-vessey added the bug Something isn't working label Nov 15, 2022
@rosiel
Copy link
Member

rosiel commented Nov 16, 2022

I prefer (and seemed to have convinced others?) that we should take all the default config stuff including this term out, and put it in the Starter Site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants