Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoUpload is ignored (because it's not listed in cfgStrings) #243

Open
imax9000 opened this issue Sep 13, 2024 · 5 comments
Open

autoUpload is ignored (because it's not listed in cfgStrings) #243

imax9000 opened this issue Sep 13, 2024 · 5 comments

Comments

@imax9000
Copy link

https://github.com/J-D-K/JKSV/blob/master/src/cfg.cpp#L23

(also, please refactor it to have the list of options in only one place. E.g., by storing lambdas or pointers to member in the map)

@jgavrus
Copy link

jgavrus commented Oct 20, 2024

hello @J-D-K, thank you for this great app.
Did you look to this issue?
now, unfortunately, auto-upload doesn't work, for now, it can be very helpful when using "dump all" option.
with a combination of these 2 features we can create a dump for all saves and send it to the cloud using 1 button

@impeeza
Copy link
Contributor

impeeza commented Oct 20, 2024

hello @J-D-K, thank you for this great app. Did you look to this issue? now, unfortunately, auto-upload doesn't work, for now, it can be very helpful when using "dump all" option. with a combination of these 2 features we can create a dump for all saves and send it to the cloud using 1 button

Please read the others issues, in special: #242 (comment)

@J-D-K
Copy link
Owner

J-D-K commented Oct 20, 2024

Sorry about this. I added the config string at some point and had to fix a bug and forgot about it when I pushed the fix if I remember correctly. Auto upload was only implemented in a build I had a couple of years ago and I don't have it anymore for whatever reason. The master branch is getting one final update to use FsLib to hopefully fix one last bug and then I'm moving on to the Rewrite for sure because the code is cleaner and easier to maintain. It's on the list of stuff I never got to finish or wanted to clean up.

@J-D-K
Copy link
Owner

J-D-K commented Oct 26, 2024

Small update. It looks like the master branch might not be getting an update and that bug that was reported to me might be complete bull somebody made up because myself and two other people can't duplicate the results and it seems to work completely fine as-is. Unless someone else can show me JKSV not working correctly with that boring whale Selfloss game, I'm moving on to the rewrite 100%.

@J-D-K
Copy link
Owner

J-D-K commented Oct 31, 2024

This is going to be tackled in the rewrite guys. I hope it won't take too long. Navigating the master branch's code is a headache for me. I know it's my own fault, but even just adding some recent changes took more time than it should have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants