Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of the separate "mask" atlas metadata being used by soca #1068

Open
travissluka opened this issue Aug 26, 2024 · 0 comments · May be fixed by #1073
Open

get rid of the separate "mask" atlas metadata being used by soca #1068

travissluka opened this issue Aug 26, 2024 · 0 comments · May be fixed by #1073
Assignees
Labels
SOCA Sea-ice, Ocean, and Coupled Assimilation

Comments

@travissluka
Copy link
Collaborator

travissluka commented Aug 26, 2024

I previously added a separate mask to u/v so that the answers would not change during one of the large C++/Fortran refactoring PRs. However, because of this there are two masks for the u/v fields, and the mask metadata is used explicitly for soca specific code.
Remove this by having u/v fields use either the normal cell center mask, or the u/v specific mask. (right now interp uses the cell center mask, and RMS calculation uses the u/v specific mask)

per conversation with @fmahebert

for the u/v fields there is today a interp_source_point_mask metadata pointing to (effectively) the array mask_h, and a mask metadata pointing to the array mask_u/v. If we want to consolidate the generic code to use just mask for the metadata, we need to do one of two things: (a) rename soca's mask metadata to something new (so the metadata name is made available for the generic code) and preserve today's functionality, or (b) change soca's behavior so there is just one mask in use for u/v, which if I understand your prior comment may depend on destaggering the u/v fields.

Ultimately, the correct thing to do is to make sure the U/V fields are destaggered, but until that day, I need to pick a single mask to use for all generic operations.

see discussion as to why this is needed, here #1056

@travissluka travissluka added the SOCA Sea-ice, Ocean, and Coupled Assimilation label Aug 26, 2024
@travissluka travissluka self-assigned this Aug 26, 2024
@travissluka travissluka linked a pull request Sep 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SOCA Sea-ice, Ocean, and Coupled Assimilation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@travissluka and others