Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALGO-72.2.1: Use VADER for insitu/potential temperature conversion/ SOCA #923

Open
2 of 5 tasks
travissluka opened this issue Jul 18, 2023 · 3 comments
Open
2 of 5 tasks
Assignees
Labels
Epic For planning and administration SOCA Sea-ice, Ocean, and Coupled Assimilation

Comments

@travissluka
Copy link
Collaborator

travissluka commented Jul 18, 2023

Description

The insitu/potential temperature conversion is currently being performed in UFO (via InsituTemperature), but this requires a separate vertical interpolation that also does this conversion. If we add a recipe to VADER to do the conversion, we can then use the generic vertical interpolator that is in UFO. We can then depreciate, and eventually remove, the InsituTemperature observation operator. The code should be cleaner and more maintainable this way.

We'll also want to sort out the model names, afterward, before this is used by other people (e.g. ROMS)

  • Add GSW support to VADER
  • Add the non-linear insitu/potential temperature recipe to VADER
  • Add the linear insitu/potential temperature recipe to VADER
  • Change the yamls in SOCA / Skylab to use the generic vertical interpolator and VADER recipe.
  • Compare the two methods (conversion in VADER vs conversion in UFO) it shouldn't make a big difference, but who knows
@travissluka travissluka added SOCA Sea-ice, Ocean, and Coupled Assimilation Epic For planning and administration labels Jul 18, 2023
@travissluka
Copy link
Collaborator Author

@hga007 FYI, since you were interested in this. We hope to get this implemented this quarter.

@symoore90 symoore90 changed the title Use VADER for insitu/potential temperature conversion ALGO-72.2.1: Use VADER for insitu/potential temperature conversion Aug 10, 2023
@symoore90 symoore90 changed the title ALGO-72.2.1: Use VADER for insitu/potential temperature conversion ALGO-72.2.1: Use VADER for insitu/potential temperature conversion/ SOCA Aug 10, 2023
@symoore90
Copy link

Extend to Q4? @travissluka

@travissluka
Copy link
Collaborator Author

Extend to Q4? @travissluka

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic For planning and administration SOCA Sea-ice, Ocean, and Coupled Assimilation
Projects
None yet
Development

No branches or pull requests

3 participants