Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It might be better to change protobuf::libprotobuf to ${Protobuf_LIBRARIES}, becasue protobuf::libprotobuf doesn't work in the lower version of cmake #59

Closed
DinghaoZhang opened this issue Oct 16, 2019 · 7 comments
Closed

It might be better to change protobuf::libprotobuf to ${Protobuf_LIBRARIES}, becasue protobuf::libprotobuf doesn't work in the lower version of cmake #59

DinghaoZhang opened this issue Oct 16, 2019 · 7 comments

Comments

@DinghaoZhang
Copy link

DinghaoZhang commented Oct 16, 2019 •
edited
Loading

In tools/onnx2bnn/CMakeLists.txt, it might be better to change protobuf::libprotobuf to ${Protobuf_LIBRARIES}, becasue protobuf::libprotobuf doesn't work in the lower version of cmake, util cmake 3.9.
@daquexian
Copy link
Contributor

Thanks! I'll fix it soon

@daquexian
Copy link
Contributor

Fixed in #60, merge after CI passes

@daquexian
Copy link
Contributor

BTW, have you joined dabnn QQ group, 1021964010?

@daquexian
Copy link
Contributor

#60 is merged, could you please verify it on your side? thanks!

@DinghaoZhang
Copy link
Author

#60 is merged, could you please verify it on your side? thanks!

I have changed it. Thank you very much. dabnn is a very useful tool.

@daquexian
Copy link
Contributor

I have changed it. Thank you very much. dabnn is a very useful tool.

Thanks!

@daquexian
Copy link
Contributor

I have changed it. Thank you very much. dabnn is a very useful tool.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daquexian @DinghaoZhang