Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X install instruction not working #627

Open
aavina opened this issue Oct 7, 2022 · 1 comment
Open

OS X install instruction not working #627

aavina opened this issue Oct 7, 2022 · 1 comment
Labels

Comments

@aavina
Copy link

aavina commented Oct 7, 2022

I get the following when running OS X instructions for the libtoxcore dependency under INSTALL.md:

➜  toxic git:(master) brew install --HEAD https://raw.githubusercontent.com/Tox/homebrew-tox/master/Formula/libtoxcore.rb
Error: Non-checksummed download of libtoxcore formula file from an arbitrary URL is unsupported! `brew extract` or `brew create` and `brew tap-new` to create a formula file in a tap on GitHub instead.

May help to replace instruction

brew install --HEAD https://raw.githubusercontent.com/Tox/homebrew-tox/master/Formula/libtoxcore.rb

with this?

brew install toxcore

Only downside is this installs the latest stable version rather than a specific version.

I'll update this issue once the command finishes to see if the rest of the instructions work after.
My make failed. I can look into it later but here's my output:

➜  toxic git:(master) make                                                                                                                                  
  CC    autocomplete.o                                                                                                                                      
In file included from /Users/*****/git/toxic/src/autocomplete.c:35:                                                                                       
In file included from /Users/*****/git/toxic/src/execute.h:26:                                                                                            
/Users/*****/git/toxic/src/toxic.h:160:73: error: unknown type name 'Tox_Group_Exit_Type'
void on_group_peer_exit(Tox *m, uint32_t groupnumber, uint32_t peer_id, Tox_Group_Exit_Type exit_type,
                                                                        ^                                                                                   
/Users/*****/git/toxic/src/toxic.h:166:59: error: unknown type name 'Tox_Group_Privacy_State'
void on_group_privacy_state(Tox *m, uint32_t groupnumber, Tox_Group_Privacy_State privacy_state, void *userdata);
                                                          ^                                                                                                 
/Users/*****/git/toxic/src/toxic.h:167:56: error: unknown type name 'Tox_Group_Topic_Lock'
void on_group_topic_lock(Tox *m, uint32_t groupnumber, Tox_Group_Topic_Lock topic_lock, void *userdata);
                                                       ^                                                                                                    
/Users/*****/git/toxic/src/toxic.h:173:54: error: unknown type name 'Tox_Group_Join_Fail'
void on_group_rejected(Tox *m, uint32_t groupnumber, Tox_Group_Join_Fail type, void *userdata);
                                                     ^          
/Users/*****/git/toxic/src/toxic.h:175:26: error: unknown type name 'Tox_Group_Mod_Event'                       
                         Tox_Group_Mod_Event type, void *userdata);                                                                                         
                         ^                                                                                                                                  
/Users/*****/git/toxic/src/toxic.h:176:57: error: unknown type name 'Tox_Group_Voice_State'                     
void on_group_voice_state(Tox *m, uint32_t groupnumber, Tox_Group_Voice_State voice_state, void *userdata);
                                                        ^                                                                                                   
In file included from /Users/*****/git/toxic/src/autocomplete.c:35:                                                                                       
In file included from /Users/*****/git/toxic/src/execute.h:27:                                                                                            
/Users/*****/git/toxic/src/windows.h:200:68: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
    void(*onGroupPeerExit)(ToxWindow *, Tox *, uint32_t, uint32_t, Tox_Group_Exit_Type, const char *, size_t, const char *,
                                                                   ^                                                                                        
/Users/*****/git/toxic/src/windows.h:206:62: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
    void(*onGroupPrivacyState)(ToxWindow *, Tox *, uint32_t, Tox_Group_Privacy_State);                            
                                                             ^                                                                                              
/Users/*****/git/toxic/src/windows.h:207:59: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
    void(*onGroupTopicLock)(ToxWindow *, Tox *, uint32_t, Tox_Group_Topic_Lock);                                  
                                                          ^                                                                                                 
/Users/*****/git/toxic/src/windows.h:210:58: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
    void(*onGroupRejected)(ToxWindow *, Tox *, uint32_t, Tox_Group_Join_Fail); 
                                                         ^       
/Users/*****/git/toxic/src/windows.h:211:80: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
    void(*onGroupModeration)(ToxWindow *, Tox *, uint32_t, uint32_t, uint32_t, Tox_Group_Mod_Event);
                                                                               ^
/Users/*****/git/toxic/src/windows.h:212:60: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
    void(*onGroupVoiceState)(ToxWindow *, Tox *, uint32_t, Tox_Group_Voice_State);
                                                           ^
6 warnings and 6 errors generated.
make: *** [/Users/*****/git/toxic/build/autocomplete.o] Error 1

Old version installs successfully

I was able to install Toxic version v0.11.3 by doing the following:

  • Uninstall toxcore from brew (if installed)
  • Clone TokTok/c-toxcore (https://github.com/TokTok/c-toxcore/)
  • Checkout c-toxcore on v0.2.13
    • I figured this version was what HEAD was around creation of Toxic v0.11.3 by referencing release dates
  • Compile and install c-toxcore (instructions)
  • Checkout toxic on tag v0.11.3
  • Compile and install toxic with DISABLE_X11=1 flag
    • I had issues where compiler couldn't find X11 based references
@JFreegman
Copy link
Owner

Maybe a Mac user can chime in here?

@JFreegman JFreegman added the bug label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants