Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the data csv (and adapt JabRef accordingly) #42

Closed
ju-sh opened this issue Oct 9, 2019 · 8 comments
Closed

Make the data csv (and adapt JabRef accordingly) #42

ju-sh opened this issue Oct 9, 2019 · 8 comments
Assignees

Comments

@ju-sh
Copy link
Contributor

ju-sh commented Oct 9, 2019

Can the data in https://github.com/JabRef/abbrv.jabref.org/blob/master/journals be stored as CSV?

Since CSV files are more structured and is a standard way of storing data. Unless jabref is more comfortable with data in its present format.

@kn-neelalohitha
Copy link

I would like to work on this!

@Siedlerchr
Copy link
Member

This would also require to modify JabRef's code for parsing and storing abbreviation files.
Currently the abbrevations are oganized as key, value. No other information is necessary.
I personally don't see any advantage in using csv, because we don't have any additional data stored.
But maybe you can describe your idea a bit more concrete?

In general we try to make changes that provide additional value and are not purely technical (of course there are exceptions).

@koppor
Copy link
Member

koppor commented Oct 9, 2019

@Siedlerchr Please not that there really is more information. See the README.md in the root of this repository (https://github.com/JabRef/abbrv.jabref.org#format-of-the-file). I highlighted the important parts:

grafik

I would really ❤️ to see the information converted to CSV and JabRef adapted accordingly.

@ju-sh
Copy link
Contributor Author

ju-sh commented Oct 10, 2019

So if it is to be converted to csv jabref itself would need to be changed. Okay. The change has to be done there first then. Thanks for your replies.

Closing this issue.

@ju-sh ju-sh closed this as completed Oct 10, 2019
@koppor koppor reopened this Oct 10, 2019
@koppor
Copy link
Member

koppor commented Oct 10, 2019

The issue is very valid. I keep it open. Maybe during #hacktoberfest someone wants to dive into this.

@koppor koppor changed the title Make the data csv Make the data csv (and adapt JabRef accordingly) Oct 10, 2019
@davidemdot davidemdot self-assigned this Oct 28, 2019
@davidemdot
Copy link
Member

It is not a definitive version, but all you can check the data files in CSV format and the JabRef adaptation.

Please give me your feedback! 😄

@Siedlerchr
Copy link
Member

Just create a PR and we can discuss the changes :)

@davidemdot
Copy link
Member

Sure! It is already done: JabRef/jabref#5538

@koppor @Siedlerchr @ju-sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants