Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new tag system ignores hierarchical keywords. Only the parent keyword is shown. #11390

Open
Siedlerchr opened this issue Jun 18, 2024 · 5 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor keywords ui
Milestone

Comments

@Siedlerchr
Copy link
Member

          The new tag system ignores hierarchical keywords. Only the parent keyword is shown.

Originally posted by @andr-groth in #10910 (comment)

@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Jun 18, 2024
@github-project-automation github-project-automation bot moved this to Normal priority in Prioritization Jun 18, 2024
@github-project-automation github-project-automation bot moved this to Normal priority in JabRef UI Improvements Jun 18, 2024
@andr-groth
Copy link

Specifically, the new tag system breaks the feature introduced in #628.

Maybe related to this issue, the dialog in Edit > Manage keywords likewise ignores hierachical keywords and only shows parent keywords.

@koppor
Copy link
Member

koppor commented Jun 19, 2024

@andr-groth Maybe you could contribute to #11026 (comment) - where we plan to restructure the whole groups/keywords/tagging (new)! system.

@Siedlerchr
Copy link
Member Author

Related discussion about hierarchical keywords https://discourse.jabref.org/t/preserve-pubmed-subject-headings-on-import/4362/1

@ryan-carpenter
Copy link

Related discussion about hierarchical keywords https://discourse.jabref.org/t/preserve-pubmed-subject-headings-on-import/4362/1

It's not a bad idea to support hierarchical keyword syntax. Just keep in mind that the data still need to be normalised during import and that hierarchical keywords complicate searching. For example, PubMed has a parentA/child1/child2 format but other databases supply MEDLINE terms one per line, resulting in keywords parentA/child1, parentA/child2.

Let's say JabRef has a syntax where

  • > denotes parent > child,
  • | denotes child1 | child2, and
  • , is the keyword separator.

JabRef would need to treat parentA > child1 | child2 as equivalent to parentA > child1, parentA > child2 to recognise matching keywords that were entered or imported in different formats. Also consider other situations such as merging the keywords from different entries.

@koppor koppor added this to the 6.0-beta milestone Sep 19, 2024
@ThiloteE
Copy link
Member

Also refs #12133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor keywords ui
Projects
Status: Free to take
Status: Normal priority
Development

No branches or pull requests

5 participants