customEditor API

[ManuelHentschel]

Hi, follow-up to #3337 and #3338 here. Is using the customEdior API (without the workaround of reopening each requested document) something you would consider at the moment?

I implemented this in https://github.com/ManuelHentschel/LaTeX-Workshop/tree/customEditor, based on the latest version of this repo, and would be happy to create a PR, work out any remaining bugs, or adapt design choices to your preferences, if you are interested.

[James-Yu]

We tried, but reverted in d6f0bad due to regressions. The most prominent one is, when the pdf is removed (e.g., during compilation. Some tools first remove then create a new pdf), custom editors will be closed by vscode. This behavior cannot be controlled, making e.g. #3642 #3659

[James-Yu]

I will have a test shortly and come back to you soon (TM)

[James-Yu]

Before the test, any idea on how to preserve the original ‘tab’ behavior? I.e. multiple tabs for a same file.

[ManuelHentschel]

Before the test, any idea on how to preserve the original ‘tab’ behavior? I.e. multiple tabs for a same file.

Currently, this does not seem to be possible (in a clean fashion). There are many requests for this feature at microsoft/vscode#41289, so maybe it will be implemented at some point.

[James-Yu]

I confirm that #3642, #3659 are fixed with the latest vscode + 723705e . The remaining issue is the original tab behavior, which I'd prefer maintaining.

As an alternative, I'd like to see the backend for singleton mode switched to customeditor, as the mode is still relatively new. I'd love to review it if you may have a PR on this. @ManuelHentschel

---

edit: If customeditor is to incorporated, the new codes shall be as isolated as possible.

[ManuelHentschel]

Sounds good, I'll try to get a PR done by the end of the week!