This repository has been archived by the owner on Jan 14, 2019. It is now read-only.
feat: fix issues with constructor method #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
armano2
commented
Jan 13, 2019
armano2
commented
- add missing resultType and typeParameters
- fix range of constructor identifier when modifiers are present
- constructor property in objects should have kind init
- remove dead code
- add missing resultType and typeParameters - fix range of constructor identifier when modifiers are present - constructor property in objects should have kind init - remove dead code
armano2
commented
Jan 13, 2019
| result.typeParameters = convertTSTypeParametersToTypeParametersDeclaration( | ||
| node.typeParameters | ||
| ); | ||
| } |
There was a problem hiding this comment.
babel parses it in this way, in objects typeParameters are assigned to Property, and in classes to methods
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 93.49% 93.71% +0.22%
==========================================
Files 8 8
Lines 1398 1401 +3
Branches 324 325 +1
==========================================
+ Hits 1307 1313 +6
+ Misses 50 49 -1
+ Partials 41 39 -2
Continue to review full report at Codecov.
|
|
Great, thanks! |
|
🎉 This PR is included in version 18.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
did you read my comment? |
|
This one? #124 (comment) |
|
yes, i'm just unsure if we should follow them on this one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.