You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's a check that looks for strings like '[rejected]' in the output, but these aren't guaranteed to appear. E.g. when authentication fails, the error string starts with 'fatal:' instead. It would be more robust to fail the script if an error is detected and the string match also failed - in this case, repeating the attempted push several times probably won't ever work anyway.
Errors as a result of
git push
are currently ignored:github-pages-deploy-action/src/git.ts
Lines 301 to 306 in 810af53
There's a check that looks for strings like '[rejected]' in the output, but these aren't guaranteed to appear. E.g. when authentication fails, the error string starts with 'fatal:' instead. It would be more robust to fail the script if an error is detected and the string match also failed - in this case, repeating the attempted push several times probably won't ever work anyway.
See the following workflow log where this error happened and was ignored, resulting in the job succeeding while the deployment did not actually succeed: https://github.com/www-learn-study/saraswati.learn.study/actions/runs/6727951896/job/18286524048, section 'Deploy preview'
This issue appears to have been introduced with #1054.
The text was updated successfully, but these errors were encountered: