Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly add dependency fast-check #180

Closed
wants to merge 1 commit into from

Conversation

keyz
Copy link
Contributor

@keyz keyz commented Dec 26, 2023

Description (What)

Since 12.0.0, pnpm add syncpack has been failing under pnpm strict mode because fast-check isn't declared as a dependency:

 ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies

.
└─┬ syncpack 12.0.0
  ├─┬ @effect/schema 0.56.0
  │ └── ✕ missing peer fast-check@^3.13.2
  └─┬ @effect/match 0.40.0
    └── ✕ unmet peer [email protected]: found 2.0.0-next.62
Peer dependencies that should be installed:
  fast-check@^3.13.2

hint: If you want peer dependencies to be automatically installed, add "auto-install-peers=true" to an .npmrc file at the root of your project.
hint: If you don't want pnpm to fail on peer dependency issues, add "strict-peer-dependencies=false" to an .npmrc file at the root of your project.

Justification (Why)

As a CLI tool, syncpack should be self-contained and shouldn't require the callsite to install peer deps

How Can This Be Tested?

Run pnpm add syncpack with a strict .npmrc:

auto-install-peers=false
strict-peer-dependencies=true

@keyz keyz changed the title Add dependency fast-check Explicitly add dependency fast-check Dec 26, 2023
@JamieMason
Copy link
Owner

Thanks @keyz, I'll add a pnpm check to CI to catch these in future (I'm using npm).

JamieMason pushed a commit that referenced this pull request Dec 26, 2023
JamieMason pushed a commit that referenced this pull request Dec 26, 2023
JamieMason pushed a commit that referenced this pull request Dec 26, 2023
JamieMason pushed a commit that referenced this pull request Dec 26, 2023
JamieMason pushed a commit that referenced this pull request Dec 26, 2023
@JamieMason
Copy link
Owner

I've switched this repo over to using pnpm strict, hopefully this is resolved in 12.0.1

@keyz
Copy link
Contributor Author

keyz commented Dec 26, 2023

Great, thank you @JamieMason!

@keyz keyz deleted the fast-check-v3 branch December 26, 2023 21:27
JamieMason added a commit that referenced this pull request Aug 25, 2024
JamieMason added a commit that referenced this pull request Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants