-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
versionGroups not working with multiple elements #43
Comments
Thanks @JasonGore, I will take a look. |
Had a look last night and I'm not too far off a fix, it'll take a me a few days mainly due to availability. One issue in the repro is that there are no sources, The WIP is on the dev branch |
Released in 5.6.10 🤞 Thanks for the handy repro, I have converted it into a test to catch any regressions: syncpack/src/commands/lib/installations/get-grouped-mismatched-dependencies.spec.ts Lines 217 to 245 in f4cb055
Please let me know if you run into any more problems, thanks. |
It worked perfectly for my actual use case, which has 12 entries. Thanks for the quick fix! |
That's great. You're welcome |
Description
I'm not sure if I'm using this feature correctly, but
versionGroups
is an array type which seems to imply it supports multiple entries. It works fine when I have one entry, but as soon as I add a second entry, it actually seems to break BOTH entries.yarn
yarn repro
Expected:
No syncpack errors.
Actual:
Syncpack seems to ignore
versionGroups
and errors:If you just delete the second entry
versionGroups
inpackage.json
from:to:
Then you actually see some of the errors resolving:
I would expect both entries to work based on the type, but beyond that, it actually seems like the second entry breaks both entries.
The text was updated successfully, but these errors were encountered: