{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":193762615,"defaultBranch":"master","name":"terminal","ownerLogin":"Jaswir","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2019-06-25T18:30:14.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/15957528?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1694852898.0","currentOid":""},"activityList":{"items":[{"before":"888f7a30bb47076ba1586b69b6f88f3054f702a5","after":"d6987a2038d7d4a5dc8b5a1b50103db2edd7ad91","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-30T20:51:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Hacky solution","shortMessageHtmlLink":"Hacky solution"}},{"before":"8f7c30de479448b7a9e3b99dfbfdb87fd78d5c8c","after":"888f7a30bb47076ba1586b69b6f88f3054f702a5","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-30T20:47:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Review ready","shortMessageHtmlLink":"Review ready"}},{"before":"739e06a7c28160e4daf8028472b50bfa5ddc1c76","after":"8f7c30de479448b7a9e3b99dfbfdb87fd78d5c8c","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-30T20:31:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Cleaned up code for review","shortMessageHtmlLink":"Cleaned up code for review"}},{"before":"d320893074906392b73de6374ffc704e3bda10ea","after":"739e06a7c28160e4daf8028472b50bfa5ddc1c76","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-30T20:23:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Fixed issue with command palette going to unfocused","shortMessageHtmlLink":"Fixed issue with command palette going to unfocused"}},{"before":"a27733be7d509a797d1964705171a0512e204407","after":"d320893074906392b73de6374ffc704e3bda10ea","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-30T18:21:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"When unfocused in Command Pallette open it should remain Acrylic!","shortMessageHtmlLink":"When unfocused in Command Pallette open it should remain Acrylic!"}},{"before":"b10b0669eb276c98c899864512d49a305f207e2a","after":"a27733be7d509a797d1964705171a0512e204407","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-30T17:51:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Fixed spelling thing","shortMessageHtmlLink":"Fixed spelling thing"}},{"before":"0620583fb17dc8707770034f5fa9cfe11f72cd84","after":"b10b0669eb276c98c899864512d49a305f207e2a","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-30T17:30:31.000Z","pushType":"push","commitsCount":42,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Merge branch 'microsoft:main' into jaswir/2531","shortMessageHtmlLink":"Merge branch 'microsoft:main' into jaswir/2531"}},{"before":"d496a5fb80d5ec002077d6be27a35ec7494cb520","after":"19efcfee9d66ae1a1638db4539dbee7e11740541","ref":"refs/heads/master","pushedAt":"2023-10-30T17:30:19.000Z","pushType":"push","commitsCount":41,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Fix spelling after inbox merge","shortMessageHtmlLink":"Fix spelling after inbox merge"}},{"before":"eed9cadd1c7604520fc8233dad14ceb74e9c3d16","after":"0620583fb17dc8707770034f5fa9cfe11f72cd84","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-23T19:57:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Main functionality added","shortMessageHtmlLink":"Main functionality added"}},{"before":"8b44940ea34e45cc9400a5cb7163646c68b9b264","after":"eed9cadd1c7604520fc8233dad14ceb74e9c3d16","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-21T15:32:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Instead of setting _runtimeUseAcrylic based on the opacity, when the opacity changes, just do the opacity < 1.0 when we actually need it.","shortMessageHtmlLink":"Instead of setting _runtimeUseAcrylic based on the opacity, when the …"}},{"before":"a16b27ac6df7fa0c8f400f1b475e737242033109","after":"8b44940ea34e45cc9400a5cb7163646c68b9b264","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-21T14:51:43.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Merge branch 'microsoft:main' into jaswir/2531","shortMessageHtmlLink":"Merge branch 'microsoft:main' into jaswir/2531"}},{"before":"174585740759f3e473c5a4efe3207a20d2c78511","after":"d496a5fb80d5ec002077d6be27a35ec7494cb520","ref":"refs/heads/master","pushedAt":"2023-10-21T14:51:31.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Fix rectangular clipboard copying initiated from the app menu (#16197)\n\ncd6b083 had 2 issues:\r\n* Improper testing with Ctrl+M instead of Edit > Mark.\r\n* Wrong SelectionState function being used. When the selection is\r\n initiated without keyboard or mouse, `IsKeyboardMarkSelection`\r\n returns false. The proper function to use is `IsLineSelection`.\r\n\r\nCloses #15153\r\n\r\n## Validation Steps Performed\r\n* Run Far\r\n* Start selection via Edit>Mark\r\n* Hold Alt while dragging to make a rectangular selection\r\n* Right click\r\n* Clipboard contains a rectangular copy ✅","shortMessageHtmlLink":"Fix rectangular clipboard copying initiated from the app menu (micros…"}},{"before":"aa5f8bca0506108b5ef42531c5d04e8a209ee9ad","after":"a16b27ac6df7fa0c8f400f1b475e737242033109","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-18T18:00:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Experimentations","shortMessageHtmlLink":"Experimentations"}},{"before":"204dab2de07df0bc517273000b9b26c4c2cfdce9","after":"aa5f8bca0506108b5ef42531c5d04e8a209ee9ad","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-18T16:25:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Ran code formatting","shortMessageHtmlLink":"Ran code formatting"}},{"before":"109abe1eca68fc7e47d70c82c8424b6006260485","after":"204dab2de07df0bc517273000b9b26c4c2cfdce9","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-18T16:19:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Acrylic toggle updated after Unfocused Acrylic update","shortMessageHtmlLink":"Acrylic toggle updated after Unfocused Acrylic update"}},{"before":"2769409171d95e8949aaf70538bb25cd4727487f","after":"109abe1eca68fc7e47d70c82c8424b6006260485","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-18T15:29:21.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Merge branch 'microsoft:main' into jaswir/2531","shortMessageHtmlLink":"Merge branch 'microsoft:main' into jaswir/2531"}},{"before":"f2c3ddd10523c146260a259a1c2ee2a85b264be8","after":"174585740759f3e473c5a4efe3207a20d2c78511","ref":"refs/heads/master","pushedAt":"2023-10-18T15:29:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Fix the color of marks (#16106)\n\nGuess what _doesn't_ have the same layout as a bitmap? A `til::color`.\r\n\r\nNoticed in 1.19.\r\n\r\nRegressed in #16006","shortMessageHtmlLink":"Fix the color of marks (microsoft#16106)"}},{"before":"652e66bc71423cf2ed9dd01feddd6d50161fa88b","after":"2769409171d95e8949aaf70538bb25cd4727487f","ref":"refs/heads/jaswir/2531","pushedAt":"2023-10-16T19:48:37.000Z","pushType":"push","commitsCount":74,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Merge branch 'microsoft:main' into jaswir/2531","shortMessageHtmlLink":"Merge branch 'microsoft:main' into jaswir/2531"}},{"before":"74748394c17c168843b511dd837268445e5dfd6c","after":"f2c3ddd10523c146260a259a1c2ee2a85b264be8","ref":"refs/heads/master","pushedAt":"2023-10-16T19:43:39.000Z","pushType":"push","commitsCount":28,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Flip bits instead of checking for them (#16160)\n\nNo need to check for if a bit is set before manually clearing or setting\r\nthem when xor will do the trick.","shortMessageHtmlLink":"Flip bits instead of checking for them (microsoft#16160)"}},{"before":"41f7ed73c1e62195919146f689135517aefbaf7b","after":"74748394c17c168843b511dd837268445e5dfd6c","ref":"refs/heads/master","pushedAt":"2023-09-26T17:04:28.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Reimplement TextBuffer::Reflow (#15701)\n\nSubjectively speaking, this commit makes 3 improvements:\r\n* Most importantly, it now would work with arbitrary Unicode text.\r\n (No more `IsGlyphFullWidth` or DBCS handling during reflow.)\r\n* Due to the simpler implementation it hopefully makes review of\r\n future changes and maintenance simpler. (~3x less LOC.)\r\n* It improves perf. by 1-2 orders of magnitude.\r\n (At 120x9001 with a full buffer I get 60ms -> 2ms.)\r\n\r\nUnfortunately, I'm not confident that the new code replicates the old\r\ncode exactly, because I failed to understand it. During development\r\nI simply tried to match its behavior with what I think reflow should do.\r\n\r\nCloses #797\r\nCloses #3088\r\nCloses #4968\r\nCloses #6546\r\nCloses #6901\r\nCloses #15964\r\nCloses MSFT:19446208\r\n\r\nRelated to #5800 and #8000\r\n\r\n## Validation Steps Performed\r\n* Unit tests ✅\r\n* Feature tests ✅\r\n* Reflow with a scrollback ✅\r\n* Reflowing the cursor cell causes a forced line-wrap ✅\r\n (Even at the end of the buffer. ✅)\r\n* `color 8f` and reflowing retains the background color ✅\r\n* Enter alt buffer, Resize window, Exit alt buffer ✅","shortMessageHtmlLink":"Reimplement TextBuffer::Reflow (microsoft#15701)"}},{"before":"abf1889ed0b0ea430cf5d6564e8ab7cd3abddec7","after":"51a676f5e9b6895bd8375ce573d9b844835da7c3","ref":"refs/heads/jaswir/11092","pushedAt":"2023-09-22T16:21:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Ran Code formatting","shortMessageHtmlLink":"Ran Code formatting"}},{"before":"f17c224053964fb6a57604664c8ede7a4577a743","after":"abf1889ed0b0ea430cf5d6564e8ab7cd3abddec7","ref":"refs/heads/jaswir/11092","pushedAt":"2023-09-22T16:13:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"added function description like with some of the other functions to describe what the new parameter does also provided clearer comments at other places","shortMessageHtmlLink":"added function description like with some of the other functions to d…"}},{"before":"711e3b1c355396bcc36d37b773920f1428688bc4","after":"f17c224053964fb6a57604664c8ede7a4577a743","ref":"refs/heads/jaswir/11092","pushedAt":"2023-09-22T14:57:06.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Merge branch 'jaswir/11092' of https://github.com/Jaswir/terminal into jaswir/11092","shortMessageHtmlLink":"Merge branch 'jaswir/11092' of https://github.com/Jaswir/terminal int…"}},{"before":"ee139a2f144d3882cadf54785343576ac02dc390","after":"711e3b1c355396bcc36d37b773920f1428688bc4","ref":"refs/heads/jaswir/11092","pushedAt":"2023-09-22T12:45:04.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Merge branch 'microsoft:main' into jaswir/11092","shortMessageHtmlLink":"Merge branch 'microsoft:main' into jaswir/11092"}},{"before":"2fa8e766bb516aa02d248e2dfe46d2b3269c3c9e","after":"41f7ed73c1e62195919146f689135517aefbaf7b","ref":"refs/heads/master","pushedAt":"2023-09-22T12:44:42.000Z","pushType":"push","commitsCount":20,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"ConPTY: Fix missing flush on console mode changes (#15991)\n\nPreviously, all unknown escape sequences would lead to an immediate call\r\nto `VtEngine::_Flush()`. This lead to problems with nushell which uses\r\nFTCS marks that were unknown to us. Combined with the linewise redrawing\r\nthat nushell does, Terminal would get the prompt in two separate frames,\r\ncausing a slight flickering.\r\n\r\n#14677 fixed this by suppressing the `_Flush()` call when unknown\r\nsequences are encountered. Unfortunately, this triggered a bug due\r\nto our somewhat \"inconsistent\" architecture in conhost:\r\n`XtermEngine::WriteTerminalW` isn't just used to flush unknown sequences\r\nbut also used directly by `InputBuffer::PassThroughWin32MouseRequest`\r\nto write its mouse sequence directly to the ConPTY host.\r\n`VtEngine` already contains a number of specialized member functions\r\nlike `RequestWin32Input()` to ensure that `_Flush()` is called\r\nimmediately and another member could've been added to solve this issue.\r\nThis commit now adds `RequestMouseMode` in the same vein.\r\n\r\nBut I believe we can make the system more robust in general by using\r\neager flushing by default (= safe), similar to how a `write()` on a\r\nTCP socket flushes by default, and instead only selectively pause and\r\nunpause flushing with a system similar to `TCP_CORK`.\r\n\r\nThis seems to work fairly well, as it solves:\r\n* The original nushell bug\r\n* The new bug\r\n* Improves overall throughput by ~33% (due to less flushing)\r\n\r\nIn particular the last point is noteworthy, as this commit removes\r\nthe last performance bottleneck in ConPTY that isn't `VtEngine`.\r\nAround ~95% of all CPU and wall time is spent in there now and any\r\nimprovements to `VtEngine` should yield immediately results.\r\n\r\nCloses #15711\r\n\r\n## Validation Steps Performed\r\n* Clone/Run https://github.com/chrisant996/repro_enable_mouse_input\r\n* Hold Ctrl+Alt and circle with the mouse over the viewport\r\n* Repro.exe prints the current cursor coordinates ✅\r\n* Run nushell\r\n* No flickering when typing in the prompt ✅","shortMessageHtmlLink":"ConPTY: Fix missing flush on console mode changes (microsoft#15991)"}},{"before":"fe58c9f51bca77966b6e55cc6c60c69b8bbd2875","after":"ee139a2f144d3882cadf54785343576ac02dc390","ref":"refs/heads/jaswir/11092","pushedAt":"2023-09-21T19:38:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Reworded the conditionals, made it more clear","shortMessageHtmlLink":"Reworded the conditionals, made it more clear"}},{"before":"012e51a7cfe30372767d7575c14532dec39d2e20","after":"fe58c9f51bca77966b6e55cc6c60c69b8bbd2875","ref":"refs/heads/jaswir/11092","pushedAt":"2023-09-21T18:38:18.000Z","pushType":"push","commitsCount":19,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Merge branch 'microsoft:main' into jaswir/11092","shortMessageHtmlLink":"Merge branch 'microsoft:main' into jaswir/11092"}},{"before":"792c0e0ce4d7d0c05adc45692bb4bcaf1927051f","after":"012e51a7cfe30372767d7575c14532dec39d2e20","ref":"refs/heads/jaswir/11092","pushedAt":"2023-09-16T18:15:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Fixed bug after reducing function calls from 2 to 1","shortMessageHtmlLink":"Fixed bug after reducing function calls from 2 to 1"}},{"before":"c3a20df0b3d859188849eaa4129e39083f3b5aa8","after":"792c0e0ce4d7d0c05adc45692bb4bcaf1927051f","ref":"refs/heads/jaswir/11092","pushedAt":"2023-09-16T17:05:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"Run Code Formatting","shortMessageHtmlLink":"Run Code Formatting"}},{"before":"3185b3d86c30056cb35bc650e8093a5afa75013c","after":"c3a20df0b3d859188849eaa4129e39083f3b5aa8","ref":"refs/heads/jaswir/11092","pushedAt":"2023-09-16T15:58:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Jaswir","name":"Jaswir","path":"/Jaswir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15957528?s=80&v=4"},"commit":{"message":"reduced calls from 2 to 1 function call, increasing performance","shortMessageHtmlLink":"reduced calls from 2 to 1 function call, increasing performance"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMC0zMFQyMDo1MTo0NS4wMDAwMDBazwAAAAOjbtVK","startCursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMC0zMFQyMDo1MTo0NS4wMDAwMDBazwAAAAOjbtVK","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wOS0xNlQxNTo1ODo0My4wMDAwMDBazwAAAAOCFlI3"}},"title":"Activity · Jaswir/terminal"}