Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clip with catalog and output_files breaks when no points are found #400

Closed
lucas-johnson opened this issue Dec 7, 2020 · 2 comments
Closed
Assignees
Labels
Bug A bug in the package Enhancement Not actually a bug but a possible improvement

Comments

@lucas-johnson
Copy link

Clipping a catalog works despite no points being found (i.e. no error), however throws an error if opt_output_files() is set. I don't think this should create an error, rather no files should be written.

clip_roi(ctg, las_plots)
#> No point found for within region of interest 1.
#> class        : LAS (v1.4 format 6)
#> memory       : 13.2 Kb 
#> extent       : 0, 0, 0, 0 (xmin, xmax, ymin, ymax)
#> coord. ref.  : NA 
#> area         : 0 units²
#> points       : 0  points
#> density      : 0 points/units²
opt_output_files(ctg) <-  "~/{RGID}"
clip_roi(ctg, las_plots)
#> No point found for within region of interest 1.
#> Error: written_path is not character it is a NULL
@Jean-Romain Jean-Romain self-assigned this Dec 7, 2020
@Jean-Romain Jean-Romain added Bug A bug in the package Enhancement Not actually a bug but a possible improvement labels Dec 7, 2020
@Jean-Romain
Copy link
Collaborator

Congrats you opened the 400th issue!

Fixed. Thanks for reporting

@lucas-johnson
Copy link
Author

Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in the package Enhancement Not actually a bug but a possible improvement
Projects
None yet
Development

No branches or pull requests

2 participants