Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested modification of the parameter max_cr_factor thresholds in silva2016 #417

Closed
sanmaral opened this issue Mar 29, 2021 · 1 comment
Assignees
Labels
Enhancement Not actually a bug but a possible improvement Feature request Asking for a new feature

Comments

@sanmaral
Copy link

sanmaral commented Mar 29, 2021

We have frequently used the silva2016 method for segmenting trees, with generally very satisfactory results. However, we encounter problems in certain forest types (dehesas, and other Mediterranean oak forests), where the diameter of the crown is often greater than the height of the tree. We have tried modifying the silva2016 function to allow us to increase the value of the max_cr_factor parameter up to 2, and this modification solved our problem. At the moment the argument is limited to take values between 0 and 1. Based on our experience, we propose to increase this range to 2 in order to be able to work satisfactorily in a wider range of forest types.

Jean-Romain added a commit that referenced this issue Mar 29, 2021
@Jean-Romain Jean-Romain self-assigned this Mar 29, 2021
@Jean-Romain Jean-Romain added Enhancement Not actually a bug but a possible improvement Feature request Asking for a new feature labels Mar 29, 2021
@Jean-Romain
Copy link
Collaborator

Thanks, max_cr_factor is now allowed to be in [0, +∞[

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Not actually a bug but a possible improvement Feature request Asking for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants