Replace DataFrame with List. #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary, as the column length may change, resulting in an object that is not a valid DataFrame. The conflicts with RcppCore/Rcpp#1099 where the object will remain a DataFrame. For the purposes of `proxy`, a List is sufficient.
4 tasks
|
This seems legit. And you are right I used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #357.
This is necessary, as the column length may change, resulting in an object that is not a valid
DataFrame. The conflicts with RcppCore/Rcpp#1099 where the object will remain aDataFrame.The underlying cause is that previously, calling push_back or push_front on a DataFrame caused the DataFrame to revert to a list, but it should remain a DataFrame.
However, there are some occasions (caught by your tests, thanks!) where proxy becomes invalid for a DataFrame (to do with column lengths). It remains a valid List.
For the purposes of
proxy, aListis sufficient.