Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa-physics: parse README.json for cook-dependent settings #43

Open
c-dilks opened this issue May 15, 2023 · 1 comment
Open

qa-physics: parse README.json for cook-dependent settings #43

c-dilks opened this issue May 15, 2023 · 1 comment
Assignees

Comments

@c-dilks
Copy link
Member

c-dilks commented May 15, 2023

Run dependent code in monitorRead.groovy is not really sustainable. Instead, consider parsing the README.json file, typically included with cooked data. For example:

{
  "recharge": false,
  "helflip": false,
}

Be careful though, after doing this, this QA code may not "catch" cases where a setting is inconsistent with prior cooks; for example, we don't notice the helicity sign convention is changed until far downstream physics analysis asymmetries flip sign...

It may be better to keep this run-dependent code and just add a warning, to catch cases when some setting differs from expectation / prior cooks.

@c-dilks c-dilks self-assigned this May 15, 2023
@c-dilks
Copy link
Member Author

c-dilks commented May 17, 2023

Important: Note that FCmode != recharge option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant