Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate/complete bash migration path #4

Open
slominskir opened this issue Mar 13, 2024 · 1 comment
Open

Investigate/complete bash migration path #4

slominskir opened this issue Mar 13, 2024 · 1 comment

Comments

@slominskir
Copy link
Member

slominskir commented Mar 13, 2024

Our production deployment currently relies on the scripts here:

https://github.com/JeffersonLab/smoothness/tree/main/bash/keycloak

The functions in these scripts have been migrated to the lib.sh file in this project.

We will ultimately remove the smoothness/tree/main/bash/keycloak scripts. However, we may need to ensure the migration is clean. It may require keeping the same script file names and updating them to use lib.sh via source/import. Need to experiment with source lib.sh and then calling functions to determine best user experience for a bash API.

@slominskir
Copy link
Member Author

The best solution is likely just adding the ability to pass a function name as an argument. Then the lib.sh could be both importable (source command) and executable so users can use it however is easiest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant