Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RecordingCompleteEvent #296

Closed
synesthesia opened this issue Jun 21, 2023 · 4 comments · Fixed by #297
Closed

Add RecordingCompleteEvent #296

synesthesia opened this issue Jun 21, 2023 · 4 comments · Fixed by #297
Assignees
@synesthesia
Labels
Enhancement New feature or request
Milestone
0.64.0

Comments

@synesthesia
Copy link
Contributor

Hi @Jericho

I've got to implement this for myself anyway as am building a function to extract zoom recordings for our business and archive them in other storage.

Would you be interested in a PR with just the one message in it? (of course including all the parsing and tests)

Julian
@Jericho
Copy link
Owner

Jericho commented Jun 21, 2023

Absolutely! I definitely welcome contributions.

@synesthesia
Copy link
Contributor Author

OK great!

My priority is to get it running in my app (where I include your code as source as I need to make a couple of minor changes elsewhere), but when I have done that I should be able to cherry pick across into a PR branch based off develop

Have tried to copy your code style exactly so hopefully will be an easy review for you.

@synesthesia
Copy link
Contributor Author

However obviously something not right in my set-up, when I run Cake locally just in the ZoomNet code getting lots of StyleCop errors, which of course in Release mode are breaking the build.... Didn't think I had touched anything around that config so will try a clean clone of my fork.

@synesthesia synesthesia mentioned this issue Jun 22, 2023
Merged
@Jericho Jericho linked a pull request Jun 22, 2023 that will close this issue
Implement RecordingCompleteEvent #297
Merged
@Jericho Jericho added the Enhancement New feature or request label Jun 23, 2023
@Jericho Jericho assigned Jericho and synesthesia and unassigned Jericho Jun 23, 2023
@Jericho Jericho added this to the 0.64.0 milestone Jun 23, 2023
@Jericho
Copy link
Owner

Jericho commented Jun 26, 2023

🎉 This issue has been resolved in version 0.64.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@synesthesia synesthesia

Labels
Enhancement New feature or request
Projects
None yet
Milestone
0.64.0
Development

Successfully merging a pull request may close this issue.

Implement RecordingCompleteEvent ssatuk/ZoomNet
2 participants
@Jericho @synesthesia