From 3dd618089097b3423733d78d2629847279573979 Mon Sep 17 00:00:00 2001
From: Jerome Ju <jeromeju@google.com>
Date: Thu, 19 Jan 2023 21:04:35 +0000
Subject: [PATCH] Remove PullRequest Resources

This commit removes the PullRequest Resources support.
This PR removes `github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1/pullrequest`
and docs for PullRequest resources.

Removal of `pipelineResources`, as in tektoncd#5967 has been broken up into removal
of each resources packages for the `small PR` code standard.
---
 docs/resources.md                             | 126 ----------
 docs/variables.md                             |  10 -
 examples/v1beta1/taskruns/pullrequest.yaml    |  35 ---
 .../pullrequest_input_copystep_output.yaml    |  50 ----
 pkg/apis/pipeline/v1beta1/resource_types.go   |   3 -
 pkg/apis/resource/resource.go                 |   3 -
 .../v1alpha1/pipeline_resource_types.go       |   5 +-
 .../v1alpha1/pipelineresource_validation.go   |  16 --
 .../pipelineresource_validation_test.go       |  40 ----
 .../pullrequest/pull_request_resource.go      | 183 --------------
 .../pullrequest/pull_request_resource_test.go | 226 ------------------
 11 files changed, 1 insertion(+), 696 deletions(-)
 delete mode 100644 examples/v1beta1/taskruns/pullrequest.yaml
 delete mode 100644 examples/v1beta1/taskruns/pullrequest_input_copystep_output.yaml
 delete mode 100644 pkg/apis/resource/v1alpha1/pullrequest/pull_request_resource.go
 delete mode 100644 pkg/apis/resource/v1alpha1/pullrequest/pull_request_resource_test.go

diff --git a/docs/resources.md b/docs/resources.md
index fd1232b8706..27e57289cba 100644
--- a/docs/resources.md
+++ b/docs/resources.md
@@ -46,7 +46,6 @@ For example:
     -   [Optional Resources](#optional-resources)
 -   [Resource types](#resource-types)
     -   [Git Resource](#git-resource)
-    -   [Pull Request Resource](#pull-request-resource)
     -   [Image Resource](#image-resource)
     -   [Storage Resource](#storage-resource)
         -   [GCS Storage Resource](#gcs-storage-resource)
@@ -455,131 +454,6 @@ spec:
 
 Note: `httpProxy`, `httpsProxy`, and `noProxy` are all optional but no validation done if all three are specified.
 
-### Pull Request Resource
-
-The `pullRequest` resource represents a pull request event from a source control
-system.
-
-Adding the Pull Request resource as an input to a `Task` will populate the
-workspace with a set of files containing generic pull request related metadata
-such as base/head commit, comments, and labels.
-
-The payloads will also contain links to raw service-specific payloads where
-appropriate.
-
-Adding the Pull Request resource as an output of a `Task` will update the source
-control system with any changes made to the pull request resource during the
-pipeline.
-
-Example file structure:
-
-```shell
-/workspace/
-/workspace/<resource>/
-/workspace/<resource>/labels/
-/workspace/<resource>/labels/<label>
-/workspace/<resource>/status/
-/workspace/<resource>/status/<status>
-/workspace/<resource>/comments/
-/workspace/<resource>/comments/<comment>
-/workspace/<resource>/head.json
-/workspace/<resource>/base.json
-/workspace/<resource>/pr.json
-```
-
-More details:
-
-Labels are empty files, named after the desired label string.
-
-Statuses describe pull request statuses. It is represented as a set of json
-files.
-
-References (head and base) describe Git references. They are represented as a
-set of json files.
-
-Comments describe a pull request comment. They are represented as a set of json
-files. Add a file or modify the `Body` field in an existing json comment file to
-interact with the PR. Files with json extension will be parsed as such.
-The content of any comments file(s) with other/no extensions will be treated as
-body field of the comment.
-
-Other pull request information can be found in `pr.json`. This is a read-only
-resource. Users should use other subresources (labels, comments, etc) to
-interact with the PR.
-
-For an example of the output this resource provides, see
-[`example`](../cmd/pullrequest-init/example).
-
-To create a pull request resource using the `PipelineResource` CRD:
-
-```yaml
-apiVersion: tekton.dev/v1alpha1
-kind: PipelineResource
-metadata:
-  name: wizzbang-pr
-  namespace: default
-spec:
-  type: pullRequest
-  params:
-    - name: url
-      value: https://github.com/wizzbangcorp/wizzbang/pulls/1
-  secrets:
-    - fieldName: authToken
-      secretName: github-secrets
-      secretKey: token
----
-apiVersion: v1
-kind: Secret
-metadata:
-  name: github-secrets
-type: Opaque
-data:
-  token: github_personal_access_token_secret # in base64 encoded form
-```
-
-Params that can be added are the following:
-
-1.  `url`: represents the location of the pull request to fetch.
-1.  `provider`: represents the SCM provider to use. This will be "guessed" based
-    on the url if not set. Valid values are `github` or `gitlab` today.
-1.  `insecure-skip-tls-verify`: represents whether to skip verification of certificates
-    from the git server. Valid values are `"true"` or `"false"`, the default being
-    `"false"`.
-
-#### Statuses
-
-The following status codes are available to use for the Pull Request resource:
-https://godoc.org/github.com/jenkins-x/go-scm/scm#State
-
-#### Pull Request
-
-The `pullRequest` resource will look for GitHub or GitLab OAuth authentication
-tokens in spec secrets with a field name called `authToken`.
-
-URLs should be of the form: https://github.com/tektoncd/pipeline/pull/1
-
-#### Self hosted / Enterprise instances
-
-The PullRequest resource works with self hosted or enterprise GitHub/GitLab
-instances. Simply provide the pull request URL and set the `provider` parameter.
-If you need to skip certificate validation set the `insecure-skip-tls-verify`
-parameter to `"true"`.
-
-```yaml
-apiVersion: tekton.dev/v1alpha1
-kind: PipelineResource
-metadata:
-  name: wizzbang-pr
-  namespace: default
-spec:
-  type: pullRequest
-  params:
-    - name: url
-      value: https://github.example.com/wizzbangcorp/wizzbang/pulls/1
-    - name: provider
-      value: github
-```
-
 ### Image Resource
 
 An `image` resource represents an image that lives in a remote repository. It is
diff --git a/docs/variables.md b/docs/variables.md
index beab1c9bc9e..d8dd1f42237 100644
--- a/docs/variables.md
+++ b/docs/variables.md
@@ -99,16 +99,6 @@ variable via `resources.inputs.<resourceName>.<variableName>` or
 | `httpsProxy` | The value of the resource's `httpsProxy` parameter. |
 | `noProxy` | The value of the resource's `noProxy` parameter. |
 
-#### Variables for the `PullRequest` type
-
-| Variable | Description |
-| -------- | ----------- |
-| `name` | The name of the resource. |
-| `type` | Type value of `"pullRequest"`.|
-| `url` | The URL of the pull request. |
-| `provider` | Provider value, either `"github"` or `"gitlab"`. |
-| `insecure-skip-tls-verify` | The value of the resource's `insecure-skip-tls-verify` parameter, either `"true"` or `"false"`. |
-
 #### Variables for the `Image` type
 
 | Variable | Description |
diff --git a/examples/v1beta1/taskruns/pullrequest.yaml b/examples/v1beta1/taskruns/pullrequest.yaml
deleted file mode 100644
index 696ed8298f3..00000000000
--- a/examples/v1beta1/taskruns/pullrequest.yaml
+++ /dev/null
@@ -1,35 +0,0 @@
-# `PipelineResources` are deprecated, consider using `Tasks` and other replacement features instead
-# https://github.com/tektoncd/pipeline/blob/main/docs/migrating-v1alpha1-to-v1beta1.md#replacing-pipelineresources-with-tasks
-apiVersion: tekton.dev/v1beta1
-kind: TaskRun
-metadata:
-  generateName: pullrequest-
-spec:
-  resources:
-    inputs:
-    - name: pr
-      resourceSpec:
-        type: pullRequest
-        params:
-        - name: url
-          # I just picked a random PR. The first couple didn't have any interesting comments or labels.
-          value: https://github.com/tektoncd/pipeline/pull/100
-  taskSpec:
-    resources:
-      inputs:
-      - name: pr
-        type: pullRequest
-    steps:
-    - name: dump-workspace
-      image: ubuntu
-      script: find $(resources.inputs.pr.path)/* -type f | xargs tail -n +1
-
-    - name: ensure-approved
-      image: ubuntu
-      script: |
-        if [ -f "$(resources.inputs.pr.path)/labels/approved" ]; then
-          echo "PR is approved!"
-        else
-          echo "PR is not approved!"
-          exit 1
-        fi
diff --git a/examples/v1beta1/taskruns/pullrequest_input_copystep_output.yaml b/examples/v1beta1/taskruns/pullrequest_input_copystep_output.yaml
deleted file mode 100644
index 7cb4a0ce18b..00000000000
--- a/examples/v1beta1/taskruns/pullrequest_input_copystep_output.yaml
+++ /dev/null
@@ -1,50 +0,0 @@
-# This examples taskrun exercises the behaviour of the pullrequest
-# resource when the output pullrequest resource matches exactly the
-# input pullrequest resource.
-#
-# A step is used to copy the input resource's data directly to the
-# output resource's workspace directory. The output resource should
-# then read the copied data and skip sending any changes to GitHub.
-#
-# Importantly the output pullrequest should _not_ fail to read the
-# data from its workspace directory, regardless of which user the
-# copy step ran as and the ownership permissions attached to the
-# pr.json file.
-#
-# `PipelineResources` are deprecated, consider using `Tasks` and other replacement features instead
-# https://github.com/tektoncd/pipeline/blob/main/docs/migrating-v1alpha1-to-v1beta1.md#replacing-pipelineresources-with-tasks
-apiVersion: tekton.dev/v1beta1
-kind: TaskRun
-metadata:
-  generateName: pr-test-copy-prjson-from-input-to-output
-spec:
-  taskSpec:
-    resources:
-      inputs:
-        - name: pr
-          type: pullRequest
-      outputs:
-        - name: pr
-          type: pullRequest
-    steps:
-    - name: copy-pr-to-output
-      image: busybox
-      script: |
-        #!/bin/sh
-        mkdir -p $(outputs.resources.pr.path)
-        cp -r $(inputs.resources.pr.path)/* $(outputs.resources.pr.path)/
-  resources:
-    inputs:
-    - name: pr
-      resourceSpec:
-        type: pullRequest
-        params:
-        - name: url
-          value: https://github.com/tektoncd/pipeline/pull/100
-    outputs:
-    - name: pr
-      resourceSpec:
-        type: pullRequest
-        params:
-        - name: url
-          value: https://github.com/tektoncd/pipeline/pull/100
diff --git a/pkg/apis/pipeline/v1beta1/resource_types.go b/pkg/apis/pipeline/v1beta1/resource_types.go
index 9f94addf9e8..41ad57bd345 100644
--- a/pkg/apis/pipeline/v1beta1/resource_types.go
+++ b/pkg/apis/pipeline/v1beta1/resource_types.go
@@ -45,9 +45,6 @@ const (
 
 	// PipelineResourceTypeImage indicates that this source is a docker Image.
 	PipelineResourceTypeImage PipelineResourceType = resource.PipelineResourceTypeImage
-
-	// PipelineResourceTypePullRequest indicates that this source is a SCM Pull Request.
-	PipelineResourceTypePullRequest PipelineResourceType = resource.PipelineResourceTypePullRequest
 )
 
 // AllResourceTypes can be used for validation to check if a provided Resource type is one of the known types.
diff --git a/pkg/apis/resource/resource.go b/pkg/apis/resource/resource.go
index 19bcc43c280..d9038dd29f7 100644
--- a/pkg/apis/resource/resource.go
+++ b/pkg/apis/resource/resource.go
@@ -24,7 +24,6 @@ import (
 	resourcev1alpha1 "github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1"
 	"github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1/git"
 	"github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1/image"
-	"github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1/pullrequest"
 	"github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1/storage"
 )
 
@@ -39,8 +38,6 @@ func FromType(name string, r *resourcev1alpha1.PipelineResource, images pipeline
 		return image.NewResource(name, r)
 	case resourcev1alpha1.PipelineResourceTypeStorage:
 		return storage.NewResource(name, images, r)
-	case resourcev1alpha1.PipelineResourceTypePullRequest:
-		return pullrequest.NewResource(name, images.PRImage, r)
 	}
 	return nil, fmt.Errorf("%s is an invalid or unimplemented PipelineResource", r.Spec.Type)
 }
diff --git a/pkg/apis/resource/v1alpha1/pipeline_resource_types.go b/pkg/apis/resource/v1alpha1/pipeline_resource_types.go
index e306bbf1b61..e588feb9184 100644
--- a/pkg/apis/resource/v1alpha1/pipeline_resource_types.go
+++ b/pkg/apis/resource/v1alpha1/pipeline_resource_types.go
@@ -43,15 +43,12 @@ const (
 	// PipelineResourceTypeImage indicates that this source is a docker Image.
 	PipelineResourceTypeImage PipelineResourceType = "image"
 
-	// PipelineResourceTypePullRequest indicates that this source is a SCM Pull Request.
-	PipelineResourceTypePullRequest PipelineResourceType = "pullRequest"
-
 	// PipelineResourceTypeGCS is the subtype for the GCSResources, which is backed by a GCS blob/directory.
 	PipelineResourceTypeGCS PipelineResourceType = "gcs"
 )
 
 // AllResourceTypes can be used for validation to check if a provided Resource type is one of the known types.
-var AllResourceTypes = []PipelineResourceType{PipelineResourceTypeGit, PipelineResourceTypeStorage, PipelineResourceTypeImage, PipelineResourceTypePullRequest}
+var AllResourceTypes = []PipelineResourceType{PipelineResourceTypeGit, PipelineResourceTypeStorage, PipelineResourceTypeImage}
 
 // +genclient
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
diff --git a/pkg/apis/resource/v1alpha1/pipelineresource_validation.go b/pkg/apis/resource/v1alpha1/pipelineresource_validation.go
index dc49cf76cf5..f4004b05b97 100644
--- a/pkg/apis/resource/v1alpha1/pipelineresource_validation.go
+++ b/pkg/apis/resource/v1alpha1/pipelineresource_validation.go
@@ -18,7 +18,6 @@ package v1alpha1
 
 import (
 	"context"
-	"fmt"
 	"strings"
 
 	"github.com/tektoncd/pipeline/pkg/apis/validate"
@@ -67,12 +66,6 @@ func (rs *PipelineResourceSpec) Validate(ctx context.Context) *apis.FieldError {
 		}
 	}
 
-	if rs.Type == PipelineResourceTypePullRequest {
-		if err := validatePullRequest(rs); err != nil {
-			return err
-		}
-	}
-
 	for _, allowedType := range AllResourceTypes {
 		if allowedType == rs.Type {
 			return nil
@@ -86,12 +79,3 @@ func (rs *PipelineResourceSpec) Validate(ctx context.Context) *apis.FieldError {
 func AllowedStorageType(gotType string) bool {
 	return gotType == PipelineResourceTypeGCS
 }
-
-func validatePullRequest(s *PipelineResourceSpec) *apis.FieldError {
-	for _, param := range s.SecretParams {
-		if param.FieldName != "authToken" {
-			return apis.ErrInvalidValue(fmt.Sprintf("invalid field name %q in secret parameter. Expected %q", param.FieldName, "authToken"), "spec.secrets.fieldName")
-		}
-	}
-	return nil
-}
diff --git a/pkg/apis/resource/v1alpha1/pipelineresource_validation_test.go b/pkg/apis/resource/v1alpha1/pipelineresource_validation_test.go
index 7fb3373f227..4f0ac3b8749 100644
--- a/pkg/apis/resource/v1alpha1/pipelineresource_validation_test.go
+++ b/pkg/apis/resource/v1alpha1/pipelineresource_validation_test.go
@@ -110,20 +110,6 @@ func TestResourceValidation_Invalid(t *testing.T) {
 				},
 			},
 			want: apis.ErrMissingField("spec.type"),
-		}, {
-			name: "pull request with invalid field name in secrets",
-			res: &v1alpha1.PipelineResource{
-				ObjectMeta: metav1.ObjectMeta{
-					Name: "temp",
-				},
-				Spec: v1alpha1.PipelineResourceSpec{
-					Type: v1alpha1.PipelineResourceTypePullRequest,
-					SecretParams: []v1alpha1.SecretParam{{
-						FieldName: "INVALID_FIELD_NAME",
-					}},
-				},
-			},
-			want: apis.ErrInvalidValue("invalid field name \"INVALID_FIELD_NAME\" in secret parameter. Expected \"authToken\"", "spec.secrets.fieldName"),
 		},
 	}
 	for _, tt := range tests {
@@ -136,32 +122,6 @@ func TestResourceValidation_Invalid(t *testing.T) {
 	}
 }
 
-func TestResourceValidation_Valid(t *testing.T) {
-	tests := []struct {
-		name string
-		res  *v1alpha1.PipelineResource
-	}{
-		{
-			name: "specify pullrequest with no secrets",
-			res: &v1alpha1.PipelineResource{
-				ObjectMeta: metav1.ObjectMeta{
-					Name: "temp",
-				},
-				Spec: v1alpha1.PipelineResourceSpec{
-					Type: v1alpha1.PipelineResourceTypePullRequest,
-				},
-			},
-		},
-	}
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			if err := tt.res.Validate(context.Background()); err != nil {
-				t.Errorf("Unexpected PipelineRun.Validate() error = %v", err)
-			}
-		})
-	}
-}
-
 func TestAllowedGCSStorageType(t *testing.T) {
 	tests := []struct {
 		name        string
diff --git a/pkg/apis/resource/v1alpha1/pullrequest/pull_request_resource.go b/pkg/apis/resource/v1alpha1/pullrequest/pull_request_resource.go
deleted file mode 100644
index efdaee48df9..00000000000
--- a/pkg/apis/resource/v1alpha1/pullrequest/pull_request_resource.go
+++ /dev/null
@@ -1,183 +0,0 @@
-/*
-Copyright 2019 The Tekton Authors
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package pullrequest
-
-import (
-	"fmt"
-	"strconv"
-	"strings"
-
-	"github.com/tektoncd/pipeline/pkg/apis/pipeline"
-	pipelinev1beta1 "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
-	resourcev1alpha1 "github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1"
-	"github.com/tektoncd/pipeline/pkg/names"
-	corev1 "k8s.io/api/core/v1"
-	"knative.dev/pkg/ptr"
-)
-
-const (
-	prSource       = "pr-source"
-	authTokenField = "authToken"
-	// nolint: gosec
-	authTokenEnv = "AUTH_TOKEN"
-)
-
-// Resource is an endpoint from which to get data which is required
-// by a Build/Task for context.
-type Resource struct {
-	Name string                                `json:"name"`
-	Type resourcev1alpha1.PipelineResourceType `json:"type"`
-
-	// URL pointing to the pull request.
-	// Example: https://github.com/owner/repo/pulls/1
-	URL string `json:"url"`
-	// SCM provider (github or gitlab today). This will be guessed from URL if not set.
-	Provider string `json:"provider"`
-	// Secrets holds a struct to indicate a field name and corresponding secret name to populate it.
-	Secrets []resourcev1alpha1.SecretParam `json:"secrets"`
-
-	PRImage                   string `json:"-"`
-	InsecureSkipTLSVerify     bool   `json:"insecure-skip-tls-verify"`
-	DisableStrictJSONComments bool   `json:"disable-strict-json-comments"`
-}
-
-// NewResource create a new git resource to pass to a Task
-func NewResource(name, prImage string, r *resourcev1alpha1.PipelineResource) (*Resource, error) {
-	if r.Spec.Type != resourcev1alpha1.PipelineResourceTypePullRequest {
-		return nil, fmt.Errorf("cannot create a PR resource from a %s Pipeline Resource", r.Spec.Type)
-	}
-	prResource := Resource{
-		Name:                      name,
-		Type:                      r.Spec.Type,
-		Secrets:                   r.Spec.SecretParams,
-		PRImage:                   prImage,
-		InsecureSkipTLSVerify:     false,
-		DisableStrictJSONComments: false,
-	}
-	for _, param := range r.Spec.Params {
-		switch {
-		case strings.EqualFold(param.Name, "URL"):
-			prResource.URL = param.Value
-		case strings.EqualFold(param.Name, "Provider"):
-			prResource.Provider = param.Value
-		case strings.EqualFold(param.Name, "insecure-skip-tls-verify"):
-			verify, err := strconv.ParseBool(param.Value)
-			if err != nil {
-				return nil, fmt.Errorf("error occurred converting %q to boolean in Pipeline Resource %s", param.Value, r.Name)
-			}
-			prResource.InsecureSkipTLSVerify = verify
-		case strings.EqualFold(param.Name, "disable-strict-json-comments"):
-			strict, err := strconv.ParseBool(param.Value)
-			if err != nil {
-				return nil, fmt.Errorf("error occurred converting %q to boolean in Pipeline Resource %s", param.Value, r.Name)
-			}
-			prResource.DisableStrictJSONComments = strict
-		}
-	}
-
-	return &prResource, nil
-}
-
-// GetName returns the name of the resource
-func (s Resource) GetName() string {
-	return s.Name
-}
-
-// GetType returns the type of the resource, in this case "Git"
-func (s Resource) GetType() resourcev1alpha1.PipelineResourceType {
-	return resourcev1alpha1.PipelineResourceTypePullRequest
-}
-
-// GetURL returns the url to be used with this resource
-func (s *Resource) GetURL() string {
-	return s.URL
-}
-
-// Replacements is used for template replacement on a PullRequestResource inside of a Taskrun.
-func (s *Resource) Replacements() map[string]string {
-	return map[string]string{
-		"name":                         s.Name,
-		"type":                         s.Type,
-		"url":                          s.URL,
-		"provider":                     s.Provider,
-		"insecure-skip-tls-verify":     strconv.FormatBool(s.InsecureSkipTLSVerify),
-		"disable-strict-json-comments": strconv.FormatBool(s.DisableStrictJSONComments),
-	}
-}
-
-// GetInputTaskModifier returns the TaskModifier to be used when this resource is an input.
-func (s *Resource) GetInputTaskModifier(ts *pipelinev1beta1.TaskSpec, sourcePath string) (pipelinev1beta1.TaskModifier, error) {
-	return &pipelinev1beta1.InternalTaskModifier{
-		StepsToPrepend: s.getSteps("download", sourcePath),
-	}, nil
-}
-
-// GetOutputTaskModifier returns a No-op TaskModifier.
-func (s *Resource) GetOutputTaskModifier(ts *pipelinev1beta1.TaskSpec, sourcePath string) (pipelinev1beta1.TaskModifier, error) {
-	return &pipelinev1beta1.InternalTaskModifier{
-		StepsToAppend: s.getSteps("upload", sourcePath),
-	}, nil
-}
-
-func (s *Resource) getSteps(mode string, sourcePath string) []pipelinev1beta1.Step {
-	args := []string{"-url", s.URL, "-path", sourcePath, "-mode", mode}
-	if s.Provider != "" {
-		args = append(args, []string{"-provider", s.Provider}...)
-	}
-	if s.InsecureSkipTLSVerify {
-		args = append(args, "-insecure-skip-tls-verify=true")
-	}
-	if s.DisableStrictJSONComments {
-		args = append(args, "-disable-strict-json-comments=true")
-	}
-
-	evs := []corev1.EnvVar{
-		{
-			Name:  "TEKTON_RESOURCE_NAME",
-			Value: s.Name,
-		},
-	}
-	for _, sec := range s.Secrets {
-		if strings.EqualFold(sec.FieldName, authTokenField) {
-			ev := corev1.EnvVar{
-				Name: authTokenEnv,
-				ValueFrom: &corev1.EnvVarSource{
-					SecretKeyRef: &corev1.SecretKeySelector{
-						LocalObjectReference: corev1.LocalObjectReference{
-							Name: sec.SecretName,
-						},
-						Key: sec.SecretKey,
-					},
-				},
-			}
-			evs = append(evs, ev)
-		}
-	}
-
-	return []pipelinev1beta1.Step{{
-		Name:       names.SimpleNameGenerator.RestrictLengthWithRandomSuffix(prSource + "-" + s.Name),
-		Image:      s.PRImage,
-		Command:    []string{"/ko-app/pullrequest-init"},
-		Args:       args,
-		WorkingDir: pipeline.WorkspaceDir,
-		Env:        evs,
-		SecurityContext: &corev1.SecurityContext{
-			// The pullrequest pipeline resource only works when running as root.
-			RunAsUser: ptr.Int64(0),
-		},
-	}}
-}
diff --git a/pkg/apis/resource/v1alpha1/pullrequest/pull_request_resource_test.go b/pkg/apis/resource/v1alpha1/pullrequest/pull_request_resource_test.go
deleted file mode 100644
index 15bb1722cba..00000000000
--- a/pkg/apis/resource/v1alpha1/pullrequest/pull_request_resource_test.go
+++ /dev/null
@@ -1,226 +0,0 @@
-/*
-Copyright 2019 The Tekton Authors
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package pullrequest_test
-
-import (
-	"testing"
-
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"knative.dev/pkg/ptr"
-
-	"github.com/google/go-cmp/cmp"
-	"github.com/tektoncd/pipeline/pkg/apis/pipeline"
-	"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
-	resourcev1alpha1 "github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1"
-	"github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1/pullrequest"
-	"github.com/tektoncd/pipeline/test/diff"
-	"github.com/tektoncd/pipeline/test/names"
-	corev1 "k8s.io/api/core/v1"
-)
-
-func TestPullRequest_NewResource(t *testing.T) {
-	url := "https://github.com/tektoncd/pipeline/pulls/1"
-	pr := &resourcev1alpha1.PipelineResource{
-		ObjectMeta: metav1.ObjectMeta{
-			Name: "foo",
-		},
-		Spec: resourcev1alpha1.PipelineResourceSpec{
-			Type: resourcev1alpha1.PipelineResourceTypePullRequest,
-			Params: []resourcev1alpha1.ResourceParam{
-				{
-					Name:  "url",
-					Value: url,
-				},
-				{
-					Name:  "provider",
-					Value: "github",
-				},
-				{
-					Name:  "disable-strict-json-comments",
-					Value: "true",
-				},
-			},
-			SecretParams: []resourcev1alpha1.SecretParam{{
-				FieldName:  "authToken",
-				SecretKey:  "test-secret-key",
-				SecretName: "test-secret-name",
-			}},
-		},
-	}
-	got, err := pullrequest.NewResource("test-resource", "override-with-pr:latest", pr)
-	if err != nil {
-		t.Fatalf("Error creating storage resource: %s", err.Error())
-	}
-
-	want := &pullrequest.Resource{
-		Name:                      "test-resource",
-		Type:                      resourcev1alpha1.PipelineResourceTypePullRequest,
-		URL:                       url,
-		Provider:                  "github",
-		Secrets:                   pr.Spec.SecretParams,
-		PRImage:                   "override-with-pr:latest",
-		InsecureSkipTLSVerify:     false,
-		DisableStrictJSONComments: true,
-	}
-	if d := cmp.Diff(want, got); d != "" {
-		t.Error(diff.PrintWantGot(d))
-	}
-}
-
-func TestPullRequest_NewResource_error(t *testing.T) {
-	pr := &resourcev1alpha1.PipelineResource{
-		ObjectMeta: metav1.ObjectMeta{
-			Name: "foo",
-		},
-		Spec: resourcev1alpha1.PipelineResourceSpec{
-			Type: resourcev1alpha1.PipelineResourceTypeGit,
-		},
-	}
-	if _, err := pullrequest.NewResource("test-resource", "override-with-pr:latest", pr); err == nil {
-		t.Error("NewPullRequestResource() want error, got nil")
-	}
-}
-
-type testcase struct {
-	in  *pullrequest.Resource
-	out []v1beta1.Step
-}
-
-const workspace = "/workspace"
-
-func containerTestCases(mode string) []testcase {
-	securityContext := &corev1.SecurityContext{
-		RunAsUser: ptr.Int64(0),
-	}
-	return []testcase{{
-		in: &pullrequest.Resource{
-			Name:                  "nocreds",
-			URL:                   "https://example.com",
-			PRImage:               "override-with-pr:latest",
-			InsecureSkipTLSVerify: false,
-		},
-		out: []v1beta1.Step{{
-			Name:            "pr-source-nocreds-9l9zj",
-			Image:           "override-with-pr:latest",
-			WorkingDir:      pipeline.WorkspaceDir,
-			Command:         []string{"/ko-app/pullrequest-init"},
-			Args:            []string{"-url", "https://example.com", "-path", workspace, "-mode", mode},
-			Env:             []corev1.EnvVar{{Name: "TEKTON_RESOURCE_NAME", Value: "nocreds"}},
-			SecurityContext: securityContext,
-		}},
-	}, {
-		in: &pullrequest.Resource{
-			Name:                  "creds",
-			URL:                   "https://example.com",
-			InsecureSkipTLSVerify: false,
-			Secrets: []resourcev1alpha1.SecretParam{{
-				FieldName:  "authToken",
-				SecretName: "github-creds",
-				SecretKey:  "token",
-			}},
-			PRImage:  "override-with-pr:latest",
-			Provider: "github",
-		},
-		out: []v1beta1.Step{{
-			Name:       "pr-source-creds-mz4c7",
-			Image:      "override-with-pr:latest",
-			WorkingDir: pipeline.WorkspaceDir,
-			Command:    []string{"/ko-app/pullrequest-init"},
-			Args:       []string{"-url", "https://example.com", "-path", "/workspace", "-mode", mode, "-provider", "github"},
-			Env: []corev1.EnvVar{
-				{Name: "TEKTON_RESOURCE_NAME", Value: "creds"},
-				{
-					Name: "AUTH_TOKEN",
-					ValueFrom: &corev1.EnvVarSource{
-						SecretKeyRef: &corev1.SecretKeySelector{
-							LocalObjectReference: corev1.LocalObjectReference{
-								Name: "github-creds",
-							},
-							Key: "token",
-						},
-					},
-				}},
-			SecurityContext: securityContext,
-		}},
-	}, {
-		in: &pullrequest.Resource{
-			Name:                  "nocreds",
-			URL:                   "https://example.com",
-			PRImage:               "override-with-pr:latest",
-			InsecureSkipTLSVerify: true,
-		},
-		out: []v1beta1.Step{{
-			Name:            "pr-source-nocreds-mssqb",
-			Image:           "override-with-pr:latest",
-			WorkingDir:      pipeline.WorkspaceDir,
-			Command:         []string{"/ko-app/pullrequest-init"},
-			Args:            []string{"-url", "https://example.com", "-path", workspace, "-mode", mode, "-insecure-skip-tls-verify=true"},
-			Env:             []corev1.EnvVar{{Name: "TEKTON_RESOURCE_NAME", Value: "nocreds"}},
-			SecurityContext: securityContext,
-		}},
-	}, {
-		in: &pullrequest.Resource{
-			Name:                      "strict-json-comments",
-			URL:                       "https://example.com",
-			PRImage:                   "override-with-pr:latest",
-			DisableStrictJSONComments: true,
-		},
-		out: []v1beta1.Step{{
-			Name:            "pr-source-strict-json-comments-78c5n",
-			Image:           "override-with-pr:latest",
-			WorkingDir:      pipeline.WorkspaceDir,
-			Command:         []string{"/ko-app/pullrequest-init"},
-			Args:            []string{"-url", "https://example.com", "-path", workspace, "-mode", mode, "-disable-strict-json-comments=true"},
-			Env:             []corev1.EnvVar{{Name: "TEKTON_RESOURCE_NAME", Value: "strict-json-comments"}},
-			SecurityContext: securityContext,
-		}},
-	}}
-}
-
-func TestPullRequest_GetDownloadSteps(t *testing.T) {
-	names.TestingSeed()
-
-	for _, tc := range containerTestCases("download") {
-		t.Run(tc.in.GetName(), func(t *testing.T) {
-			ts := v1beta1.TaskSpec{}
-			got, err := tc.in.GetInputTaskModifier(&ts, workspace)
-			if err != nil {
-				t.Fatal(err)
-			}
-			if d := cmp.Diff(tc.out, got.GetStepsToPrepend()); d != "" {
-				t.Error(diff.PrintWantGot(d))
-			}
-		})
-	}
-}
-
-func TestPullRequest_GetOutputSteps(t *testing.T) {
-	names.TestingSeed()
-
-	for _, tc := range containerTestCases("upload") {
-		t.Run(tc.in.GetName(), func(t *testing.T) {
-			ts := v1beta1.TaskSpec{}
-			got, err := tc.in.GetOutputTaskModifier(&ts, workspace)
-			if err != nil {
-				t.Fatal(err)
-			}
-			if d := cmp.Diff(tc.out, got.GetStepsToAppend()); d != "" {
-				t.Error(diff.PrintWantGot(d))
-			}
-		})
-	}
-}