Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong render in changelog file that use CRLF #182

Closed
danygold opened this issue Jul 9, 2023 · 0 comments · Fixed by #183
Closed

Wrong render in changelog file that use CRLF #182

danygold opened this issue Jul 9, 2023 · 0 comments · Fixed by #183
Labels
bug Something isn't working

Comments

@danygold
Copy link
Contributor

danygold commented Jul 9, 2023

Describe the bug
Plugin currently fully supports only CHANGELOG.md files that use LF line separator. Using a different line separator can leads wrong markdown/html/plain text render.
PR #177 resolve a regression introduced in 2.1.0 version of plugin, and take stability to the patchchangelog task, but there are some other bugs that are present.

Main bug are:

  • HTML render generate wrong link
  • HTML render generate an HTML that contains unnedeed new line
  • Plain text render generate a wrong formatting (E.g. duplicated empty line)
  • Markdown render add an unnecessary newline between links

To Reproduce
Please check this test repository. I added some unit test, and the result can be view at this link

Expected behavior
Output of the plugin is consistent with all line separator.

Environment:

  • OS: Windows
  • Gradle Changelog Plugin Version 2.1.1
  • Gradle Version 8.1.1

Additional context
This issue isn't a regression of a recent version of plugin (2.0.0 is the last version that i tested for a possible regression)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant