Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use room linked to the channel #58

Closed
tytan652 opened this issue Jul 15, 2021 · 3 comments
Closed

Option to use room linked to the channel #58

tytan652 opened this issue Jul 15, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@tytan652
Copy link
Contributor

tytan652 commented Jul 15, 2021

Is your feature request related to a problem? Please describe.
I'm actually trying to provide a chat overlay for OBS Studio, it actually use Matterbridge API as message provider.
Matterbridge can also unify different chat solution as one for the overlay enabling a nice double-stream chat overlay.
The issue is that only PeerTube require to change the room in the config for each live on the same channel. And restarting Matterbridge if someone else is using the solution is not a good idea.
Using permanent live which unfortunately use live slot even if not streaming, so it's not a solution.

Describe the solution you'd like
So I thought, what about creating a room related to the channel and make channel's live able to use it when needed.
It will add an option when creating a video to use a room related to the channel rather than the video.
So any live from the same channel with this option enabled will provide the same room.

It could also enable the possibility to recover the room, if a crash happen on a non-permanent live.
Note: There is no need to keep the room alive all the time.

Describe alternatives you've considered
Like I said changing the config manually on the server each time is not convenient and worse if someone is already streaming and using the solution.

Additional context
I tried to implement it myself but I'm beginner at JS/TS but I don't think I'd be able to make it.
If you want I can push my draft of the attempt in my repo.

@JohnXLivingston
Copy link
Owner

I understand your need. I think I will add this to my roadmap. But I can't promise you a release date.
No need to commit your attempt.

@tytan652
Copy link
Contributor Author

tytan652 commented Jul 16, 2021

The fact that you add it to your roadmap is enough. When I ask for a feature, I wait for something like "yes, I will implement it in a future version" or a "no, this feature is not worth it more explanation", not a release date

@JohnXLivingston JohnXLivingston self-assigned this Jul 19, 2021
@JohnXLivingston JohnXLivingston added the enhancement New feature or request label Jul 19, 2021
@JohnXLivingston
Copy link
Owner

This feature is available in the v4.0.0, that was just release: https://github.com/JohnXLivingston/peertube-plugin-livechat/blob/v4.0.0/CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants