Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update safe-smart-account usage #1290

Closed
kronosapiens opened this issue Sep 13, 2024 · 1 comment
Closed

Update safe-smart-account usage #1290

kronosapiens opened this issue Sep 13, 2024 · 1 comment
Labels

Comments

@kronosapiens
Copy link
Member

With the release of v1.4.0, the Safe team has renamed their contracts (changelog).

We should update our imports to use this new version, as the build scripts are currently failing on https://github.com/JoinColony/contractDeployment/tree/moreScripts-hardhat

@kronosapiens
Copy link
Member Author

kronosapiens commented Sep 13, 2024

Note that this issue can be resolved by updating the build command from:

  return run('git', ['submodule', 'update', '--init', '--recursive', '--remote'], { cwd: CONTRACT_CWD });

to

  return run('git', ['submodule', 'update', '--init'], { cwd: CONTRACT_CWD });

which matches the command run in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant