Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity check address/key usability #1391

Open
AdamISZ opened this issue Oct 29, 2022 · 1 comment
Open

Sanity check address/key usability #1391

AdamISZ opened this issue Oct 29, 2022 · 1 comment

Comments

@AdamISZ
Copy link
Member

AdamISZ commented Oct 29, 2022

Having recently been pointed at this, it makes me think that there is value in the following:

At the moment that Joinmarket creates a new address for deposit (including change), it could/should do a sanity check sign and verify operation to ensure that the created address (and not only pubkey) matches what the algorithms expect.

This would be an attempt to defend against the possibility of a low level hardware failure (e.g. bitflip) that results in the creation of an address/scriptPubKey that can't be solved, i.e. can't be spent from.

There's probably several details needed to refine/expand on the above.

@kristapsk
Copy link
Member

Concept ACK. Had similar ideas in my mind when read about this LND issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants