Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab error for 8va 15va etc. ottava line usage #572

Open
mkj42 opened this issue Aug 12, 2024 · 14 comments · Fixed by #622 or #623
Open

tab error for 8va 15va etc. ottava line usage #572

mkj42 opened this issue Aug 12, 2024 · 14 comments · Fixed by #622 or #623
Labels
backport Needs a backport from upstream bug workaround A workaround is available

Comments

@mkj42
Copy link

mkj42 commented Aug 12, 2024

This is an old issue. I am surprised to not see it in the issues list, even if just for posterity.
https://musescore.org/en/node/29986 (2014)
https://musescore.org/en/node/140896 (2016)
https://musescore.org/en/node/267830 (2017)
https://musescore.org/en/node/309239 (2020)

In any stringed instrument (?, I haven't checked them all), if you add an ottava line for transposition, 2 incorrect things happen:

  1. The ottava line is visible on the tab staff; it should only be visible on the standard staff.
  2. The notes do not change displayed fret/string number on the tab staff; they should. They sound at the correct new pitch, but are still written at the original octave.

tab 8va error.zip

tab 8va error

Here is where it gets interesting: it somehow works fine in a 4.4 nightly:
OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore Studio version (64-bit): 4.4.0-242210305, revision: github-musescore-musescore-23820f3
Is there any chance this could be understood and backported?
Fingers crossed.

Edit: (8 September 2024)
For posterity, here is what had been my updated workaround, using invisible clefs and a non-transposing dummy ottava palette:
https://musescore.org/en/node/194161 (2017/2022/2024)

@Jojo-Schmitz Jojo-Schmitz added bug backport Needs a backport from upstream workaround A workaround is available labels Aug 12, 2024
@worldwideweary
Copy link

For the record, this is what 4.4nightly does:

8vams44.webm

It doesn't naively add 12 to each string (and what of a 15 instead of 8? brotha needs a cut-away) but reforms the tab positioning, so if the user programmed the tab on the "appropriate" strings but then put an 8va on the linked treble staff, that information looks like it'd be lost. Probably just a "necessary evil" for this kind of thing. Good luck to Jojo for backporting :)

@mkj42
Copy link
Author

mkj42 commented Aug 12, 2024

I have a guess, but it's just a guess to how it's done:
Move the pitch an amount. Where does that resulting pitch fall on the neck?
So 8, 15, 22, up and down... pitch first, string/fret second.

I am prestty sure MS defaults to the lowest fret possible.
It's nowhere near adding 12 frets to any of them.
In my six string example, if you add 8va the low E becomes 4th string 2nd fret and doesn't climb the neck 'til it needs to.

Even when using my workaround I need to tweak things.
I don't expect MS to nail everything, just at least get the pitches and notation right.
The user can/must do the rest; it would still be tons better,

@mkj42
Copy link
Author

mkj42 commented Aug 20, 2024

My workaround has a shortcoming:
If the new dummy ottava line crosses a system, any hidden transposing clefs will be visible at each next system. This results in wrong notation, as it is now showing as double transposed.
It's a band-aid for some situations at least; I didn't notice the shortcoming until just now.

@Jojo-Schmitz
Copy link
Owner

Jojo-Schmitz commented Sep 8, 2024

musescore#24561 finally brought light into this

@mkj42
Copy link
Author

mkj42 commented Sep 8, 2024

I never really swarched for 'capo' or 'pitch offset'.
@cbjeukendrup showed the way.

@Jojo-Schmitz
Copy link
Owner

Jojo-Schmitz commented Sep 8, 2024

Same here. And when I searched for ottava I didn't go that far back...

@Jojo-Schmitz
Copy link
Owner

Please check whether that PR fixes it for you

@mkj42
Copy link
Author

mkj42 commented Sep 8, 2024

All great, thank you so much.

@mkj42 mkj42 closed this as completed Sep 8, 2024
@mkj42
Copy link
Author

mkj42 commented Sep 8, 2024

Fair warning, sorry I didn't notice it imeediately:
Though ottava now behaves visibly, it is doing the thing I heard about:
Once an ottava line is enterred, you cannot edit the numbers / string location on the tab staff anymore.
I don't know if that warrants re-opening, calling it a new problem, or just investigating.
I believe it was solved.
It's fine in 4.4.1 at least.

@mkj42
Copy link
Author

mkj42 commented Sep 8, 2024

Still semi-open:
musescore#20398
Semi-fixed:
musescore#14218
musescore#20240

@Jojo-Schmitz Jojo-Schmitz reopened this Sep 9, 2024
@mkj42
Copy link
Author

mkj42 commented Sep 9, 2024

I just tried the latest
OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore version (64-bit): 3.7.0.10766410234, revision: GitHub-Jojo-Schmitz-MuseScore-3eb04bd

Tab is still un-editable.
Can you withdraw these releases until this gets sorted?
I didn't wish to make things worse.

Even if we get to a point where the keyboard works but not click/dragging I would call that a win.
I personally never knew click/dragging was supposed to be an option in the first place.

@Jojo-Schmitz
Copy link
Owner

Jojo-Schmitz commented Sep 9, 2024

Check #623
With that we should be on par with Mu4 here...

@mkj42
Copy link
Author

mkj42 commented Sep 9, 2024

Excellent
Again, thank you
Now to re-re-edit my six or so posts on the forum :)

@mkj42 mkj42 closed this as completed Sep 9, 2024
@Jojo-Schmitz Jojo-Schmitz reopened this Sep 9, 2024
@Jojo-Schmitz
Copy link
Owner

Let's leave it upen until a fix for musescore#20398 is available and can get backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Needs a backport from upstream bug workaround A workaround is available
Projects
None yet
3 participants