Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't change current working dir when parsing template #33

Closed
pilvy opened this issue Jan 8, 2020 · 2 comments
Closed

Don't change current working dir when parsing template #33

pilvy opened this issue Jan 8, 2020 · 2 comments

Comments

@pilvy
Copy link

pilvy commented Jan 8, 2020

In parseSubFile(), os.Chdir() is called to parse the template more easily. I suggest refactoring this function to not affect the process' working environment.
@kataras
Copy link
Contributor

kataras commented Feb 14, 2020

Hi @pilvy, this is a serious issue and bad design, we've just found it when using iris. See kataras/iris#1450.

I am preparing a fork to solve that, probably push a PR too.

@kataras kataras mentioned this issue Feb 14, 2020
Merged
@kataras
Copy link
Contributor

kataras commented Feb 14, 2020

Fixed on #34

@Joker Joker closed this as completed in 5238456 Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kataras