Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude dependencies from final jar #40

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

MatrixTunnel
Copy link
Contributor

This should be a non-breaking change and will reduce the jar size

@JorelAli
Copy link
Owner

JorelAli commented Jan 7, 2019

It doesn't necessarily reduce the jar size, since by default the dependency scope is "compile" and are not shaded into the jar, thus supplied at runtime. However, since this is good practice for a maven dependency and I'm always looking for ways to improve my knowledge of maven, I'll merge this.

@JorelAli JorelAli merged commit 8d32eca into JorelAli:master Jan 7, 2019
@MatrixTunnel
Copy link
Contributor Author

I'm actually shading the CommandAPI into my plugin jar and I noticed it was a little large after updating the version. I looked in the jar and found that bukkit along with brigadier was shaded into it.

In this case with spigot, the bukkit and brigadier code is provided when the plugin is loaded so there's no need to include it

@JorelAli
Copy link
Owner

JorelAli commented Jan 8, 2019

I see! Thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants