Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: "Initializing GitHub repository" freezes if manual Git commit unlock passphrase needed #1275

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 23, 2024 · 2 comments · Fixed by #1615
Closed
3 tasks done
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Jan 23, 2024

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Some users set up an SSH key passphrase for their Git commits. Sometimes those phrases are needed to be manually input for making a Git commit.

In that case, the create-typescript-app CLI should allow the user to enter their passphrase when making a commit.

Actual

The prompt sticks to "Initializing GitHub repository..." and doesn't accept the passphrase input.

Terminal screenshot showing "Initializing GitHub repository..." and part of a "Please enter the passphrase to unlock..." notice

(I think all the info there is public, but blurring just in case...)

Additional Info

I'd originally set mine up to be automatic but at some point it switched to needing manual re-entry every hour or so. I've been meaning to fix that for ages... but hey, the result is I found this bug. So that's nice!

I tried passing in "stdio": "pipe" as $ options and that did seem to allow typing in. But some characters kept getting dropped I think. passphrases were getting reported as wrong, and sometimes I needed to press Enter multiple times... maybe an issue to be filed on Clack?

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Jan 23, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🐛 Bug: "Initializing GitHub repository freezes if manual Git commit unlock passphrase needed 🐛 Bug: "Initializing GitHub repository" freezes if manual Git commit unlock passphrase needed Apr 30, 2024
@omnidan
Copy link

omnidan commented May 2, 2024

A workaround I found until this is fixed, is running the script with the --skip-github-api option.

That will prevent it from going into the "Initializing GitHub repository" step and instead print a list of commands to manually run to initialize the repository.

Unfortunately, running these steps in the recommended order also did not seem to work, as they only work on existing repositories (I got an error from GitHub Cannot update default branch for an empty repository. Please init the repository and push first.).

What I did then to make it work is first manually create the repository using the steps from GitHub, but adding all code from the repo to it already, then pushing it, and then running the create-typescript-app command from the first recommended step again. Then all that's left to do is the following:

It's a bit more complicated than just running a command, but you still get to use most of the template to get it up and running, just the GitHub repo needs to be set up manually.

Copy link

🎉 This is included in version v1.67.5 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants