-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding flat_params function #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @pebeto .
I don't understand why you now return a dictionary, where previously we returned a named tuple (which is what the doc-string example returns). Is there a good reason for returning a dictionary? (Incidentally, you can also merge
named tuples). Dictionaries have the disadvantage of losing the information about the order of the properties, which could be inconvenient, don't you think?
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #177 +/- ##
==========================================
+ Coverage 88.97% 89.21% +0.23%
==========================================
Files 8 8
Lines 372 380 +8
==========================================
+ Hits 331 339 +8
Misses 41 41
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This PR solves the requested by @ablaom in #176. The previous implementation has been simplified by the use of the holy traits pattern.