Element type of an OffsetArray must match that of the parent array

[jishnub]

OffsetArray merely provides a map between indices, so it should always have the same element type as the parent array. Currently something like this is possible:

julia> b = OffsetArray{Float64,2,Matrix{ComplexF64}}(zeros(ComplexF64,2,2), (1,1))
2×2 OffsetArray(::Array{Complex{Float64},2}, 2:3, 2:3) with eltype Float64 with indices 2:3×2:3:
 0.0+0.0im  0.0+0.0im
 0.0+0.0im  0.0+0.0im

julia> b[1]
0.0 + 0.0im

julia> eltype(b)
Float64

This should be a bug. Would disallowing this be construed as a breaking change?

[johnnychen94]

Good catch!

we may just add one more type check in

OffsetArrays.jl/src/OffsetArrays.jl

Lines 95 to 98 in 87666ee

	function OffsetArray{T, N, AA}(parent::AA, offsets::NTuple{N, Int}) where {T, N, AA<:AbstractArray}
	@boundscheck overflow_check.(axes(parent), offsets)
	new{T, N, AA}(parent, offsets)
	end

a patch release seems good to me.

[timholy]

Clearly a bugfix. If it breaks anything, well it's just a case of