Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

judge does not work when the commits have different dependency versions #137

Open
shashi opened this issue Sep 2, 2021 · 1 comment
Open

Comments

@shashi
Copy link
Collaborator

shashi commented Sep 2, 2021

I'm trying to run a benchmark against master vs PR where the PR bumps a dependency version one breaking level up. But it fails to checkout the older version on the master branch. I find it confusing that it says " └─restricted to versions 0.15.2 by an explicit requirement — no versions left" for the dependency, but then I never quite understand Pkg errors.

Here is the output: https://github.com/JuliaSymbolics/Symbolics.jl/pull/365/checks?check_run_id=3495273188#step:7:268

I also tried having using Pkg; Pkg.resolve() at the top of benchmark.jl, but get the same error.

@palday
Copy link

palday commented Aug 22, 2023

what about

judge(Symbolics, 
      BenchmarkConfig(;id="origin/HEAD", juliacmd=`julia -O3 -e'using Pkg; Pkg.update()'`);
      verbose=false)

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants