DSP.jl and Unitful.jl

[jonschumacher]

Hi,

I just tried to resample a signal which is supplied as Unitful volts.

This runs fine:

julia> test = [1 2 3 4]
1×4 Matrix{Int64}:
 1  2  3  4

julia> resample(test, 1//2, dims=2)
1×2 Matrix{Float64}:
 0.718048  3.40596

But this doesn't

julia> test = [1 2 3 4]u"V"
1×4 Matrix{Quantity{Int64, 𝐋^2 𝐌 𝐈^-1 𝐓^-3, Unitful.FreeUnits{(V,), 𝐋^2 𝐌 𝐈^-1 𝐓^-3, nothing}}}:
 1 V  2 V  3 V  4 V

julia> resample(test, 1//2, dims=2)
ERROR: DimensionError: V and 0.0 are not dimensionally compatible.

Am I missing some important point or is DSP.jl not working together with Unitful (yet)? I could not find any issues related to it, but I think it would be an awesome improvement of the package to be able to work with units.

Cheers
Jonas

[martinholters]

Sure, if we can make this just work, that would certainly be nice. And we can do this one by one. But someone has to do the work, and apparently, those who have been contributing to DSP so far did not care too much about compatibility with Unitful, so they may not be too motivated to do so now. But if you want to give it a shot, a PR would be welcome.