Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters.PolynomialRatio docs mention continuous-time case in description, but not {:s} #467

Open
dnadlinger opened this issue Mar 21, 2022 · 1 comment
Open

Filters.PolynomialRatio docs mention continuous-time case in description, but not {:s} #467

dnadlinger opened this issue Mar 21, 2022 · 1 comment
Labels
documentation

Comments

@dnadlinger
Copy link
Contributor

Currently, https://docs.juliadsp.org/stable/filters/#DSP.Filters.PolynomialRatio shows the two definitions for a rational transfer function in the s and z domains. However, the syntax needed to use the continuous-time case, the :s type parameter, isn't mentioned anywhere.

This is quite confusing, especially since the continuous-time case is mentioned first in the description.
@martinholters
Copy link
Member

Completely agree. I just missed to properly update the documentation in #284.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dnadlinger @martinholters @wheeheee