Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV.Row2 supports getindex, but CSV.Row does not #500

Closed
ianfiske opened this issue Sep 17, 2019 · 1 comment
Closed

CSV.Row2 supports getindex, but CSV.Row does not #500

ianfiske opened this issue Sep 17, 2019 · 1 comment

Comments

@ianfiske
Copy link

ianfiske commented Sep 17, 2019 •
edited
Loading

Just checking if there is a reason why we don't want to have getindex for CSV.Row. It makes some operations a lot easier. It's already there for CSV.Row2

CSV.jl/src/rows.jl

Line 224 in f046da7

@inline Base.@propagate_inbounds function Base.getindex(r::Row2, i::Int)
.
@ianfiske ianfiske changed the title CSV.Row supports getindex, but CSV.Row does not CSV.Row2 supports getindex, but CSV.Row does not Sep 17, 2019
@ianfiske ianfiske changed the title CSV.Row2 supports getindex, but CSV.Row does not CSV.Row2 supports getindex, but CSV.Row does not Sep 17, 2019
@quinnj quinnj mentioned this issue Oct 7, 2019
Merged
@quinnj
Copy link
Member

quinnj commented Oct 8, 2019

Fixed in #510

@quinnj quinnj closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianfiske @quinnj