Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building DataFrames.jl on windows requires admin privileges #1754

Closed
felipenoris opened this issue Mar 27, 2019 · 5 comments
Closed

Building DataFrames.jl on windows requires admin privileges #1754

felipenoris opened this issue Mar 27, 2019 · 5 comments

Comments

@felipenoris
Copy link

felipenoris commented Mar 27, 2019

This happens due to CodecZlib.jl .

See JuliaIO/CodecZlib.jl#43 .

@bkamins
Copy link
Member

bkamins commented Mar 27, 2019

@nalimilan - I have wanted to remove readtable and writetable form the package sources for some time now. This is yet another argument for it (and it should make DataFrames.jl have lighter dependencies in general + load a bit faster on startup).

@nalimilan
Copy link
Member

We could drop readtable, but it sounds quite easy to drop the additional dependencies, so... See #1755.

@davidanthoff
Copy link
Contributor

Shouldn't this just be fixed in BinaryProvider? There seems to be an issue already: JuliaPackaging/BinaryProvider.jl#149.

@bkamins
Copy link
Member

bkamins commented Mar 28, 2019

Yes - this is a long known issue. I simply think that we do not need these dependencies in DataFrames.jl anyway (in general my view is that DataFrames.jl should be 100% Julia including all its dependencies).

@bkamins
Copy link
Member

bkamins commented Mar 28, 2019

Just to expand on for possible future readers of this thread:

DataFrames.jl should be 100% Julia including all its dependencies

We want to be sure that when DataFrames.jl fails badly (e.g. core dumps) this must mean only one of the following two reasons:

  • there is a bug in Base
  • an unsafe operation in-built into the language (like @inbounds) was used

so that the user can exclude the possible cause that e.g. some third-party C code used by DataFrames.jl has a bug.
This is in practice very relevant as columns of DataFrame can have a myriad of sources. People often report that DataFrames.jl fails. As of now - when we exclude the two points above by doing code analysis of DataFrames.jl functions only we can safely say that the bug is not in DataFrames.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants