Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing DataStreams.jl integration #1773

Closed
bkamins opened this issue Apr 11, 2019 · 2 comments
Closed

Removing DataStreams.jl integration #1773

bkamins opened this issue Apr 11, 2019 · 2 comments

Comments

@bkamins
Copy link
Member

bkamins commented Apr 11, 2019

Before the coming release we probably should deprecate DataStreams-based IO for DataFrames.jl. So that we can remove it in the next release.

The relevant code is at the end of src/abstractdataframe/io.jl file.

CC @quinnj, @nalimilan

@oxinabox
Copy link
Contributor

Reason for this is the Tables.jl has replaced that?

@bkamins
Copy link
Member Author

bkamins commented Apr 11, 2019

@quinnj (who is a best person to comment on the way we should go - that is why I have opened an issue not a PR) mentioned earlier that this should be needed now.

In particular, if what you say is true (or it is not 100% true, but the functionality is not needed currently), we can reduce loading time of DataFrames.jl by 0.5 sec, which is a part of solving problems discussed in #1764.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants